From 137a80b9bf2f6c01467cd18838a55f6726f1bb13 Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Sat, 20 Jan 2024 12:42:11 -0600 Subject: [PATCH 1/2] Directly attach stdin of server process by default --- bin/mc-send-to-console | 5 +++++ scripts/start-finalExec | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/bin/mc-send-to-console b/bin/mc-send-to-console index d1f70ebfdb9..9f1762a372f 100755 --- a/bin/mc-send-to-console +++ b/bin/mc-send-to-console @@ -2,6 +2,11 @@ . "/start-utils" : "${CONSOLE_IN_NAMED_PIPE:=/tmp/minecraft-console-in}" +if isFalse "${CREATE_CONSOLE_IN_PIPE:-false}"; then + echo "ERROR: console pipe needs to be enabled by setting CREATE_CONSOLE_IN_PIPE to true" +fi + + if [ $# = 0 ]; then echo "ERROR: pass console commands as arguments" exit 1 diff --git a/scripts/start-finalExec b/scripts/start-finalExec index e48ddb0dd2c..7d2b1091b76 100755 --- a/scripts/start-finalExec +++ b/scripts/start-finalExec @@ -231,8 +231,10 @@ fi mcServerRunnerArgs=( --stop-duration "${STOP_DURATION:-60}s" ---named-pipe "${CONSOLE_IN_NAMED_PIPE:-/tmp/minecraft-console-in}" ) +if isTrue "${CREATE_CONSOLE_IN_PIPE:-false}"; then + mcServerRunnerArgs+=(--named-pipe "${CONSOLE_IN_NAMED_PIPE:-/tmp/minecraft-console-in}") +fi if [[ ${STOP_SERVER_ANNOUNCE_DELAY} ]]; then mcServerRunnerArgs+=(--stop-server-announce-delay "${STOP_SERVER_ANNOUNCE_DELAY}s") fi From ee9ac47cc0c8089ab5ce6372557a17ef055f5f78 Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Sat, 20 Jan 2024 13:05:27 -0600 Subject: [PATCH 2/2] Pull in mc-server-runner 1.11.0 --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 4854fe85433..f0a57453b71 100644 --- a/Dockerfile +++ b/Dockerfile @@ -44,7 +44,7 @@ RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT} \ --var version=${MC_MONITOR_VERSION} --var app=mc-monitor --file {{.app}} \ --from ${GITHUB_BASEURL}/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz -ARG MC_SERVER_RUNNER_VERSION=1.10.0 +ARG MC_SERVER_RUNNER_VERSION=1.11.0 RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT} \ --var version=${MC_SERVER_RUNNER_VERSION} --var app=mc-server-runner --file {{.app}} \ --from ${GITHUB_BASEURL}/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz