chore(build): move to scikitbuild-core (scikit-build#455)

* Maintain support for testing wheels for Python 2.7 & 3.5 (on Windows)
  by adding the `test_old_pythons` GitHub workflow job.

* Drop support for building sdist on Python 2.7 and 3.6

* Add support for editable install with Python >= 3.4 using the default "redirect" mode.

* Add support for building and testing Python 3.x wheels using Python 3.12.

* Update GitHub workflow macOS runner from `macos-11` to `macos-14`.

Co-authored-by: Henry Schreiner <[email protected]>
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>

Author: 3 people

.github/workflows/build.yml

@@ -27,7 +27,7 @@ env:
 jobs:
   lint:
     name: Lint
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
@@ -44,43 +44,43 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "x86_64"
             build: "manylinux_"
             use_qemu: false
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "x86_64"
             build: "musllinux_"
             use_qemu: false
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "i686"
             build: "manylinux_"
             use_qemu: false
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "i686"
             build: "musllinux_"
             use_qemu: false
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "aarch64"
             build: "manylinux_"
             use_qemu: true
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "aarch64"
             build: "musllinux_"
             use_qemu: true
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "ppc64le"
             build: "manylinux_"
             use_qemu: true
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "ppc64le"
             build: "musllinux_"
             use_qemu: true
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "s390x"
             build: "manylinux_"
             use_qemu: true
-          - os: ubuntu-22.04
+          - os: ubuntu-latest
             arch: "s390x"
             build: "musllinux_"
             use_qemu: true
@@ -96,8 +96,8 @@ jobs:
             arch: "x86"
             build: ""
             use_qemu: false
-          - os: macos-11
-            arch: "x86_64"
+          - os: macos-14
+            arch: "universal2"
             build: ""
             use_qemu: false
 
@@ -121,13 +121,13 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: (!matrix.use_qemu) || fromJSON(env.USE_QEMU)
         with:
-          name: Wheel-${{ matrix.os }}-${{ matrix.build }}${{ matrix.arch }}
+          name: Wheel-${{ runner.os }}-${{ matrix.build }}${{ matrix.arch }}
           path: ./wheelhouse/*.whl
 
   build_manylinux2010_wheels:
     name: Build ${{ matrix.arch }} manylinux2010 wheels
     needs: [lint]
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -153,10 +153,53 @@ jobs:
           name: Wheel-manylinux2010-${{ matrix.arch }}
           path: ./wheelhouse/*.whl
 
+  test_old_pythons:
+    name: Test wheel with python ${{ matrix.python }}
+    needs: [build_wheels]
+    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python: ["2.7", "3.5"]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        if: matrix.python != '2.7'
+        name: Install Python ${{ matrix.python }}
+        with:
+          python-version: ${{ matrix.python }}
+
+      - name: Install Python ${{ matrix.python }}
+        if: matrix.python == '2.7'
+        shell: bash
+        run: |
+          nuget install python2 -Version 2.7.18 -OutputDirectory '${{ runner.temp }}'
+          echo '${{ runner.temp }}\python2.2.7.18\tools' >> $GITHUB_PATH
+
+      - name: Install dependencies
+        shell: bash
+        run: |
+          python -m pip install -U pip
+          python -m pip install pytest pytest-cov
+
+      - uses: actions/download-artifact@v4
+        with:
+          name: Wheel-Windows-AMD64
+          path: wheelhouse
+
+      - name: Install wheel
+        shell: bash
+        run: |
+          python -m pip -V
+          python -m pip install "$(find wheelhouse -name '*.whl')[test]"
+
+      - name: Test installed SDist
+        run: python -m pytest ./tests
+
   build_sdist:
     name: Build source distribution
     needs: [lint]
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -173,36 +216,24 @@ jobs:
   test_sdist:
     name: Test SDist with python ${{ matrix.python }}
     needs: [build_sdist]
-    # 22.04 doesn't have 2.7 or 3.6
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        python: ["2.7", "3.6", "3.12"]
+        python: ["3.7", "3.12"]
 
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
-        if: matrix.python != '2.7'
         name: Install Python ${{ matrix.python }}
         with:
           python-version: ${{ matrix.python }}
 
-      - name: Install Ubuntu Python 2.7
-        if: matrix.python == '2.7'
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y --no-install-recommends python2 python3-virtualenv
-          virtualenv -p python2 ${HOME}/cp27
-          ${HOME}/cp27/bin/python -m pip install -U pip
-          ${HOME}/cp27/bin/python -m pip install -U setuptools wheel
-          echo "${HOME}/cp27/bin" >> $GITHUB_PATH
-
       - name: Install dependencies
         run: |
           sudo apt-get update
           sudo apt-get install -y --no-install-recommends libssl-dev
-          pip install -r requirements-test.txt
+          pip install pytest pytest-cov
 
       - uses: actions/download-artifact@v4
         with:
@@ -211,8 +242,9 @@ jobs:
 
       - name: Install SDist
         env:
-          SKBUILD_CONFIGURE_OPTIONS: "-DBUILD_CMAKE_FROM_SOURCE:BOOL=OFF"
+          CMAKE_ARGS: "-DBUILD_CMAKE_FROM_SOURCE:BOOL=OFF"
         run: |
+          pip -V
           pip install dist/*.tar.gz
           rm -rf dist
 
@@ -221,8 +253,8 @@ jobs:
 
   check_dist:
     name: Check dist
-    needs: [build_wheels, build_manylinux2010_wheels, build_sdist, test_sdist]
-    runs-on: ubuntu-22.04
+    needs: [build_wheels, build_manylinux2010_wheels, test_old_pythons, build_sdist, test_sdist]
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/download-artifact@v4
         with:

.gitignore

@@ -30,6 +30,7 @@ develop-eggs
 .installed.cfg
 lib
 lib64
+wheelhouse
 
 # Installer logs
 pip-log.txt

CMakeLists.txt

@@ -460,5 +460,4 @@ include\(\"${CMakeProject_BINARY_DIR}/cmake_install.cmake\")
       install(${type} ${file} DESTINATION "${relative_directory}" ${_permissions})
     endforeach()
   endif()
-
 endif()

MANIFEST.in

@@ -1,54 +1,95 @@
 [build-system]
-requires = [
-    "scikit-build>=0.12",
-    "setuptools>=42",
-    "setuptools-scm[toml]",
+requires = ["scikit-build-core"]
+build-backend = "scikit_build_core.build"
+
+[project]
+name = "cmake"
+description = "CMake is an open-source, cross-platform family of tools designed to build, test and package software"
+keywords = ["CMake", "build", "c++", "fortran", "cross-platform", "cross-compilation"]
+readme = "README.rst"
+license = {text = "Apache 2.0"}
+authors = [
+    {name = "Jean-Christophe Fillion-Robin", email = "[email protected]"},
+]
+classifiers = [
+    "License :: OSI Approved :: Apache Software License",
+    "License :: OSI Approved :: BSD License",
+    "Programming Language :: C",
+    "Programming Language :: C++",
+    "Programming Language :: Fortran",
+    "Programming Language :: Python",
+    "Operating System :: OS Independent",
+    "Development Status :: 5 - Production/Stable",
+    "Intended Audience :: Developers",
+    "Topic :: Software Development :: Build Tools",
+    "Typing :: Typed"
+]
+dynamic = ["version"]
+# requires-python = ">=3.7"  this is only required to build the wheel. We're still compatible with python 2.7
+
+[project.urls]
+Homepage = "https://cmake.org"
+Documentation = "https://cmake-python-distributions.readthedocs.io"
+Source = "ttps://github.com/scikit-build/cmake-python-distributions"
+"Mailing list" = "https://groups.google.com/forum/#!forum/scikit-build"
+"Bug Tracker" = "https://github.com/scikit-build/cmake-python-distributions/issues"
+
+[project.optional-dependencies]
+test = [
+  "coverage>=4.2",
+  "importlib_metadata>=2.0; python_version<'3.10'",
+  "pytest>=3.0.3",
+  "pytest-cov>=2.4.0",
 ]
-build-backend = "setuptools.build_meta"
+
+[project.scripts]
+cmake = "cmake:cmake"
+cpack = "cmake:cpack"
+ctest = "cmake:ctest"
+
+[tool.scikit-build]
+minimum-version = "0.8"
+build-dir = "build/{wheel_tag}"
+metadata.version.provider = "scikit_build_core.metadata.setuptools_scm"
+ninja.make-fallback = false
+sdist.include = ["src/cmake/_version.py"]
+wheel.py-api = "py2.py3"
+wheel.expand-macos-universal-tags = true
+wheel.install-dir = "cmake/data"
 
 [tool.setuptools_scm]
 write_to = "src/cmake/_version.py"
+# Setuptools-scm includes type annotations in the default template
+write_to_template = "version = '{version}'"
 
 [tool.cibuildwheel]
 build = "cp39-*"
-before-all = [
-    'pipx install -f --pip-args="-c {project}/constraints-ci.txt" cmake',
-    'cmake --version',
-    'pipx install -f --pip-args="-c {project}/constraints-ci.txt" ninja',
-    'ninja --version',
-]
-before-build = "pip install -r requirements-repair.txt"
-repair-wheel-command = "python scripts/repair_wheel.py -w {dest_dir} {wheel}"
 test-extras = "test"
 test-command = "pytest {project}/tests"
 build-verbosity = 1
 
 [tool.cibuildwheel.linux]
 before-all = [
-    'pipx install -f --pip-args="-c {project}/constraints-ci.txt" cmake',
-    'cmake --version',
-    'pipx install -f --pip-args="-c {project}/constraints-ci.txt" ninja',
-    'ninja --version',
     './scripts/manylinux-build-and-install-openssl.sh',
 ]
-environment = { SKBUILD_CONFIGURE_OPTIONS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DCMAKE_CXX_STANDARD:STRING=11" }
+environment = { CMAKE_ARGS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DCMAKE_CXX_STANDARD:STRING=11" }
 
 [[tool.cibuildwheel.overrides]]
 select = ["*-manylinux_aarch64", "*-manylinux_ppc64le", "*-manylinux_s390x"]
 # disable tests on those platforms, QEMU is taking to long for jobs to pass on GHA
-environment = { SKBUILD_CONFIGURE_OPTIONS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DCMAKE_CXX_STANDARD:STRING=11 -DRUN_CMAKE_TEST:BOOL=OFF" }
+environment = { CMAKE_ARGS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DCMAKE_CXX_STANDARD:STRING=11 -DRUN_CMAKE_TEST:BOOL=OFF" }
 
 [[tool.cibuildwheel.overrides]]
 select = ["*-musllinux_x86_64", "*-musllinux_i686"]
 # disable some tests
 # - BootstrapTest fails with custom OpenSSL and probably does not make much sense for this project
 # - ExportImport|RunCMake.install|RunCMake.file-GET_RUNTIME_DEPENDENCIES: c.f. https://discourse.cmake.org/t/cmake-test-suite-failing-on-alpine-linux/5064
-environment = { SKBUILD_CONFIGURE_OPTIONS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DRUN_CMAKE_TEST_EXCLUDE:STRING='BootstrapTest|ExportImport|RunCMake.install|RunCMake.file-GET_RUNTIME_DEPENDENCIES'" }
+environment = { CMAKE_ARGS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DRUN_CMAKE_TEST_EXCLUDE:STRING='BootstrapTest|ExportImport|RunCMake.install|RunCMake.file-GET_RUNTIME_DEPENDENCIES'" }
 
 [[tool.cibuildwheel.overrides]]
 select = ["*-musllinux_aarch64", "*-musllinux_ppc64le", "*-musllinux_s390x"]
 # disable tests on those platforms, QEMU is taking to long for jobs to pass on GHA
-environment = { SKBUILD_CONFIGURE_OPTIONS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DRUN_CMAKE_TEST:BOOL=OFF" }
+environment = { CMAKE_ARGS = "-DOPENSSL_ROOT_DIR:PATH=/usr/local/ssl -DCMAKE_JOB_POOL_COMPILE:STRING=compile -DCMAKE_JOB_POOL_LINK:STRING=link -DCMAKE_JOB_POOLS:STRING=compile=4;link=1 -DRUN_CMAKE_TEST:BOOL=OFF" }
 
 [tool.cibuildwheel.macos.environment]
 MACOSX_DEPLOYMENT_TARGET = "10.10"