Support bracketed paste events #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize bracketed paste events, and set a flag on Gui if a paste is active. Application code can use this to handle carriage returns or tabs differently when they come from a paste operation.
When pasting, Ghostty seems to convert all \n to \r for some reason. Convert them back to \n so that we can handle them normally. I have to admit that I'm confused as to why this is necessary. From what I understand from Ghostty's source code (e.g. ghostty-org/ghostty@010338354a0) it does this conversion only for non-bracketed paste mode, but I'm seeing it in bracketed paste mode, and it is only there that we convert it back.
My assumption is that pressing command-V on a non-editable view is always a mistake; it would execute arbitrary commands depending on what's in the clipboard, so prevent it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed as part of jesseduffield/lazygit#4234.