use assert.NoError

Chris McDonnell · Chris McDonnell · commit 0d38051ccbfb · 2025-05-04T20:50:03.000-04:00
diff --git a/pkg/config/app_config_test.go b/pkg/config/app_config_test.go
@@ -779,10 +779,9 @@ func TestAllBranchesLogCmdMigrations(t *testing.T) {
 	for _, s := range scenarios {
 		t.Run(s.name, func(t *testing.T) {
 			actual, err := computeMigratedConfig("path doesn't matter", []byte(s.input))
-			if err != nil {
-				t.Error(err)
+			if assert.NoError(t, err) {
+				assert.Equal(t, s.expected, string(actual))
 			}
-			assert.Equal(t, s.expected, string(actual))
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -779,10 +779,9 @@ func TestAllBranchesLogCmdMigrations(t *testing.T) {`
`779`	`779`	`for _, s := range scenarios {`
`780`	`780`	`t.Run(s.name, func(t *testing.T) {`
`781`	`781`	`actual, err := computeMigratedConfig("path doesn't matter", []byte(s.input))`
`782`		`- if err != nil {`
`783`		`- t.Error(err)`
	`782`	`+ if assert.NoError(t, err) {`
	`783`	`+ assert.Equal(t, s.expected, string(actual))`
`784`	`784`	`}`
`785`		`- assert.Equal(t, s.expected, string(actual))`
`786`	`785`	`})`
`787`	`786`	`}`
`788`	`787`	`}`