Skip to content

Commit 01fb4b9

Browse files
committed
Merge branch 'BDomzalski-patch-1'
2 parents 6686869 + e82693d commit 01fb4b9

File tree

5 files changed

+22
-21
lines changed

5 files changed

+22
-21
lines changed

angular-dropdowns.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ dd.directive('dropdownSelect', ['DropdownService',
6868
scope: {
6969
dropdownSelect: '=',
7070
dropdownModel: '=',
71+
dropdownItemLabel: '@',
7172
dropdownOnchange: '&'
7273
},
7374

74-
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
75-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
75+
controller: ['$scope', '$element', function ($scope, $element) {
76+
$scope.labelField = $scope.dropdownItemLabel || 'text';
7677

7778
DropdownService.register($element);
7879

@@ -131,11 +132,12 @@ dd.directive('dropdownMenu', ['$parse', '$compile', 'DropdownService', '$templat
131132
scope: {
132133
dropdownMenu: '=',
133134
dropdownModel: '=',
135+
dropdownItemLabel: '@',
134136
dropdownOnchange: '&'
135137
},
136138

137-
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
138-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
139+
controller: ['$scope', '$element', function ($scope, $element) {
140+
$scope.labelField = $scope.dropdownItemLabel || 'text';
139141

140142
var $template = angular.element($templateCache.get('ngDropdowns/templates/dropdownMenu.html'));
141143
// Attach this controller to the element's data
@@ -233,4 +235,4 @@ dd.factory('DropdownService', ['$document',
233235
return service;
234236
}
235237
]);
236-
})(window, window.angular);
238+
})(window, window.angular);

bower.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-dropdowns",
3-
"version": "1.0.0",
3+
"version": "1.1.0",
44
"homepage": "https://github.com/jseppi/angular-dropdowns",
55
"authors": [
66
"James Seppi <[email protected]> (http://github.com/jseppi)",
@@ -11,7 +11,8 @@
1111
"tlvince",
1212
"dinodsaurus",
1313
"elishacook",
14-
"alexisbg"
14+
"alexisbg",
15+
"BDomzalski"
1516
],
1617
"description": "AngularJS Dropdown Directives",
1718
"main": [

dist/angular-dropdowns.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ dd.directive('dropdownSelect', ['DropdownService',
6868
scope: {
6969
dropdownSelect: '=',
7070
dropdownModel: '=',
71+
dropdownItemLabel: '@',
7172
dropdownOnchange: '&'
7273
},
7374

74-
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
75-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
75+
controller: ['$scope', '$element', function ($scope, $element) {
76+
$scope.labelField = $scope.dropdownItemLabel || 'text';
7677

7778
DropdownService.register($element);
7879

@@ -131,11 +132,12 @@ dd.directive('dropdownMenu', ['$parse', '$compile', 'DropdownService', '$templat
131132
scope: {
132133
dropdownMenu: '=',
133134
dropdownModel: '=',
135+
dropdownItemLabel: '@',
134136
dropdownOnchange: '&'
135137
},
136138

137-
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
138-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
139+
controller: ['$scope', '$element', function ($scope, $element) {
140+
$scope.labelField = $scope.dropdownItemLabel || 'text';
139141

140142
var $template = angular.element($templateCache.get('ngDropdowns/templates/dropdownMenu.html'));
141143
// Attach this controller to the element's data
@@ -233,4 +235,4 @@ dd.factory('DropdownService', ['$document',
233235
return service;
234236
}
235237
]);
236-
})(window, window.angular);
238+
})(window, window.angular);

dist/angular-dropdowns.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-dropdowns",
3-
"version": "1.0.0",
3+
"version": "1.1.0",
44
"author": {
55
"name": "James Seppi",
66
"email": "[email protected]",
@@ -23,7 +23,8 @@
2323
"tlvince",
2424
"dinodsaurus",
2525
"elishacook",
26-
"alexisbg"
26+
"alexisbg",
27+
"BDomzalski"
2728
],
2829
"repository": {
2930
"type": "git",
@@ -37,11 +38,6 @@
3738
"gulp-rename": "^1.2.0",
3839
"gulp-rimraf": "^0.1.0",
3940
"gulp-uglify": "^0.3.2",
40-
"jshint-stylish": "^0.4.0",
41-
"karma": "^0.12.22"
42-
},
43-
"engines": {
44-
"node": "0.10.x",
45-
"npm": "1.4.x"
41+
"jshint-stylish": "^0.4.0"
4642
}
4743
}

0 commit comments

Comments
 (0)