Add relative-json-pointer test with empty string #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It's helpful for reviewers when submitting PRs to try to include references to the behavior you're testing. For reference, here that's https://json-schema.org/draft/2020-12/json-schema-validation.html#name-json-pointers and https://datatracker.ietf.org/doc/html/draft-handrews-relative-json-pointer-01#section-3 (where yes it seems this indeed is correctly invalid). Thanks for submitting. |
Julian
added a commit
to python-jsonschema/jsonschema
that referenced
this pull request
Nov 28, 2022
(This is unlike non-relative pointers, where empty strings are indeed valid.) Refs: json-schema-org/JSON-Schema-Test-Suite#605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.