Skip to content

Conversation

@matbesancon
Copy link
Contributor

include 1.0 and nightly in Travis (allowing for failures on nightly)

include 1.0 and nightly in Travis (allowing for failures on nightly)
@mlubin
Copy link
Member

mlubin commented Aug 27, 2018

I'm not sure nightly is worth running right now. JuliaOpt has a shared queue for Travis (so this can slow down CI results for all repos), and we have a big enough job getting things running on 1.0 that I don't expect to look at the nightly results for a while.

@matbesancon
Copy link
Contributor Author

Do you think 1.0 should be allowed failure?

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #32 into master will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
- Coverage   48.13%   47.2%   -0.94%     
=========================================
  Files           3       3              
  Lines         644     644              
=========================================
- Hits          310     304       -6     
- Misses        334     340       +6
Impacted Files Coverage Δ
src/MOIWrapper.jl 70.98% <0%> (-1.24%) ⬇️
src/ClpCInterface.jl 33.59% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f882274...64e4c43. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Aug 27, 2018

If it's not passing right now, then yes :)

.travis.yml Outdated

notifications:
email: false
script:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current failure on Julia v1.0 is due to this line and the two below. Just delete them

@matbesancon
Copy link
Contributor Author

passing now

@mlubin
Copy link
Member

mlubin commented Aug 27, 2018

This isn't testing anything on 1.0 at the moment: https://travis-ci.org/JuliaOpt/Clp.jl/jobs/421176547#L148. See @blegat's suggestion.

@blegat
Copy link
Member

blegat commented Aug 28, 2018

The script: should be removed.

.travis.yml Outdated

after_success:
- julia -e 'cd(Pkg.dir("Clp")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'
- julia -e 'using Pkg; cd(Pkg.dir("Clp")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do using Compat; using Compat.Pkg for it work on Julia v0.6

@mlubin mlubin merged commit 1eab843 into jump-dev:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants