Skip to content

Conversation

@rmannibucau
Copy link
Contributor

@rmannibucau rmannibucau commented Jun 12, 2019

Overview

Proposing a pattern using @timeout for "wait until" like tests.


I hereby agree to the terms of the JUnit Contributor License Agreement.

@sbrannen
Copy link
Member

Tentatively slated for 5.5 GA for team discussion

@sbrannen sbrannen changed the title adding an example of @Timeout usage for 'wait until' logic in tests Add example of @Timeout usage for 'wait until' logic in tests Jun 13, 2019
@sbrannen
Copy link
Member

I generally recommend the use of Awaitility for such use cases.

So, if we add an example like this in the User Guide we should also point the users to third-party solutions such as Awaitility.

Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes and point the users to third-party solutions such as Awaitility.

@sbrannen
Copy link
Member

Team Decision: include such content, and we should also point the users to third-party solutions such as Awaitility.

@sbrannen
Copy link
Member

in progress: with the intent of fixing the Spotless violation and polishing locally before merging into master

@sbrannen sbrannen changed the title Add example of @Timeout usage for 'wait until' logic in tests Add a @Timeout example for 'wait until' logic Jun 30, 2019
@sbrannen sbrannen changed the title Add a @Timeout example for 'wait until' logic Add a @Timeout example for 'poll until' logic Jun 30, 2019
@sbrannen sbrannen closed this in e6006fe Jun 30, 2019
sbrannen added a commit that referenced this pull request Jun 30, 2019
@sbrannen
Copy link
Member

This has been merged into master in e6006fe and further refined in 4f2da09.

Thanks for the PR!

In the future, please be mindful of the following.

  • Example test classes in the documentation project must have the Demo suffix in order to be included in the build.
  • Example test methods must be annotated with @Test.
  • Sections in the User Guide require explicit anchors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants