Skip to content

Conversation

@philskillz-coder
Copy link

fixed some typehints etc, look through

@sourcery-ai
Copy link

sourcery-ai bot commented May 6, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 1.59 ⭐ 1.63 ⭐ 0.04 👎
Method Length 28.41 ⭐ 28.77 ⭐ 0.36 👎
Working memory 6.07 ⭐ 6.19 ⭐ 0.12 👎
Quality 82.93% 82.70% -0.23% 👎
Other metrics Before After Change
Lines 567 607 40
Changed files Quality Before Quality After Quality Change
imoog/init.py % % %
imoog/app.py 85.27% ⭐ 84.75% ⭐ -0.52% 👎
imoog/opengraph.py 92.44% ⭐ 92.44% ⭐ 0.00%
imoog/views.py 59.20% 🙂 59.57% 🙂 0.37% 👍
imoog/cache/basecache.py 100.00% ⭐ 100.00% ⭐ 0.00%
imoog/cache/memorycache.py 93.97% ⭐ 93.93% ⭐ -0.04% 👎
imoog/cache/rediscache.py 89.22% ⭐ 89.22% ⭐ 0.00%
imoog/database/drivers.py 99.10% ⭐ 99.10% ⭐ 0.00%
imoog/database/mongo.py 91.25% ⭐ 91.25% ⭐ 0.00%
imoog/database/postgres.py 84.63% ⭐ 83.15% ⭐ -1.48% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
imoog/views.py deliver_file 8 ⭐ 156 😞 11 😞 52.55% 🙂 Try splitting into smaller methods. Extract out complex expressions
imoog/views.py upload_file 3 ⭐ 156 😞 10 😞 59.31% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant