Updated rubocop to 1.23

Author: anakinj

.codeclimate.yml

@@ -0,0 +1,10 @@
+plugins:
+  fixme:
+    enabled: true
+  bundler-audit:
+    enabled: true
+  shellcheck:
+    enabled: true
+  rubocop:
+    enabled: true
+    channel: rubocop-1-23-0

.rubocop.yml

@@ -1,12 +1,14 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.6
+  NewCops: enable
+  SuggestExtensions: false
 
 Gemspec/RequiredRubyVersion:
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Layout/CaseIndentation:
@@ -15,7 +17,7 @@ Layout/CaseIndentation:
 Style/AsciiComments:
   Enabled: false
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
 Style/CollectionMethods:
@@ -30,10 +32,6 @@ Style/BlockDelimiters:
   Exclude:
     - spec/**/*_spec.rb
 
-Style/BracesAroundHashParameters:
-  Exclude:
-    - spec/**/*_spec.rb
-
 Style/GuardClause:
   Enabled: false
 
@@ -53,15 +51,15 @@ Style/SignalException:
   Enabled: false
 
 Metrics/AbcSize:
-  Max: 20
+  Max: 25
 
 Metrics/ClassLength:
   Max: 101
 
 Metrics/ModuleLength:
   Max: 100
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: false
 
 Metrics/BlockLength:
@@ -74,7 +72,7 @@ Metrics/MethodLength:
 Style/SingleLineBlockParams:
   Enabled: false
 
-Lint/EndAlignment:
+Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
 Style/FormatString:
@@ -92,7 +90,7 @@ Style/WordArray:
 Style/RedundantSelf:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: true
   EnforcedLastArgumentHashStyle: always_ignore
 

.rubocop_todo.yml

@@ -1,24 +1,39 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-12-21 23:11:43 +0200 using RuboCop version 0.52.1.
+# `rubocop --auto-gen-config --exclude-limit 1000000`
+# on 2021-12-27 06:53:55 UTC using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'gemfiles/openssl.gemfile'
+    - 'gemfiles/rbnacl.gemfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
 # Include: **/*.gemspec
-Gemspec/OrderedDependencies:
+Gemspec/RequireMFA:
   Exclude:
     - 'ruby-jwt.gemspec'
 
-# Offense count: 1
+# Offense count: 10
 # Cop supports --auto-correct.
-Layout/EmptyLines:
+Layout/EmptyLineAfterGuardClause:
   Exclude:
-    - 'spec/integration/readme_examples_spec.rb'
+    - 'lib/jwt/algos/ecdsa.rb'
+    - 'lib/jwt/algos/eddsa.rb'
+    - 'lib/jwt/algos/rsa.rb'
+    - 'lib/jwt/decode.rb'
+    - 'lib/jwt/jwk.rb'
+    - 'lib/jwt/jwk/rsa.rb'
+    - 'lib/jwt/verify.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -30,15 +45,25 @@ Layout/EmptyLinesAroundBlockBody:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'spec/jwk_spec.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'lib/jwt/algos/ecdsa.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: normal, rails
+# SupportedStyles: normal, indented_internal_methods
 Layout/IndentationConsistency:
   Exclude:
     - 'spec/jwt_spec.rb'
@@ -79,10 +104,27 @@ Layout/SpaceInsideBlockBraces:
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Exclude:
     - 'bin/console.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'spec/integration/readme_examples_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'Appraisals'
+
+# Offense count: 1
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/jwt/jwk/key_base.rb'
+
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
@@ -92,27 +134,64 @@ Lint/UnusedBlockArgument:
     - 'spec/jwk/ec_spec.rb'
     - 'spec/jwt/verify_spec.rb'
 
-# Offense count: 2
-Metrics/CyclomaticComplexity:
-  Max: 7
-
 # Offense count: 1
-Metrics/PerceivedComplexity:
-  Max: 8
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 25
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: MaxKeyValuePairs.
-Performance/RedundantMerge:
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: ==, equal?, eql?
+Style/ClassEqualityComparison:
   Exclude:
-    - 'spec/jwt_spec.rb'
+    - 'lib/jwt/algos/rsa.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/Encoding:
   Exclude:
     - 'lib/jwt/version.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'ruby-jwt.gemspec'
+
+# Offense count: 19
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Appraisals'
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'bin/console.rb'
+    - 'gemfiles/openssl.gemfile'
+    - 'gemfiles/rbnacl.gemfile'
+    - 'gemfiles/standalone.gemfile'
+    - 'lib/jwt/algos/ecdsa.rb'
+    - 'lib/jwt/algos/eddsa.rb'
+    - 'lib/jwt/algos/hmac.rb'
+    - 'lib/jwt/algos/none.rb'
+    - 'lib/jwt/algos/ps.rb'
+    - 'lib/jwt/algos/rsa.rb'
+    - 'lib/jwt/algos/unsupported.rb'
+    - 'lib/jwt/claims_validator.rb'
+    - 'lib/jwt/default_options.rb'
+    - 'lib/jwt/security_utils.rb'
+    - 'ruby-jwt.gemspec'
+    - 'spec/jwt/algos/ecdsa_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/HashTransformKeys:
+  Exclude:
+    - 'lib/jwt/claims_validator.rb'
+    - 'lib/jwt/encode.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: InverseMethods, InverseBlocks.
@@ -122,43 +201,77 @@ Style/InverseMethods:
 
 # Offense count: 2
 # Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
 Style/MethodCallWithoutArgsParentheses:
   Exclude:
     - 'spec/jwt_spec.rb'
 
-# Offense count: 2
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: module_function, extend_self
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/jwt/algos.rb'
-    - 'lib/jwt/signature.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
-Style/MutableConstant:
+# Configuration parameters: EnforcedStyle, Autocorrect.
+# SupportedStyles: module_function, extend_self, forbidden
+Style/ModuleFunction:
   Exclude:
-    - 'lib/jwt/version.rb'
+    - 'lib/jwt/signature.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 6
 
+# Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/jwt.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/ParallelAssignment:
   Exclude:
     - 'spec/integration/readme_examples_spec.rb'
 
-# Offense count: 11
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Exclude:
+    - 'lib/jwt/encode.rb'
+    - 'lib/jwt/jwk/ec.rb'
+    - 'lib/jwt/jwk/hmac.rb'
+    - 'lib/jwt/jwk/rsa.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/RedundantRegexpEscape:
+  Exclude:
+    - 'spec/jwk/decode_with_jwk_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/jwt/encode.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SlicingWithRange:
+  Exclude:
+    - 'lib/jwt/security_utils.rb'
+
+# Offense count: 27
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
     - 'bin/console.rb'
+    - 'gemfiles/openssl.gemfile'
+    - 'gemfiles/rbnacl.gemfile'
+    - 'gemfiles/standalone.gemfile'
     - 'spec/jwk/ec_spec.rb'
     - 'spec/jwk/rsa_spec.rb'
     - 'spec/jwk_spec.rb'
@@ -177,9 +290,3 @@ Style/TrailingCommaInArguments:
 Style/UnlessElse:
   Exclude:
     - 'spec/jwt_spec.rb'
-
-# Offense count: 162
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 420

Gemfile

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rubocop', '~> 0.52.0' # Same as codeclimate default
+gem 'rubocop', '~> 1.23.0' # Same as codeclimate default