Skip to content

Commit 8139dcc

Browse files
bobrikdavem330
authored andcommitted
udp6: add a missing call into udp_fail_queue_rcv_skb tracepoint
The tracepoint has existed for 12 years, but it only covered udp over the legacy IPv4 protocol. Having it enabled for udp6 removes the unnecessary difference in error visibility. Signed-off-by: Ivan Babrou <[email protected]> Fixes: 296f7ea ("udp: add tracepoints for queueing skb to rcvbuf") Acked-by: Paolo Abeni <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 3a7af34 commit 8139dcc

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

net/core/net-traces.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,6 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(napi_poll);
6363
EXPORT_TRACEPOINT_SYMBOL_GPL(tcp_send_reset);
6464
EXPORT_TRACEPOINT_SYMBOL_GPL(tcp_bad_csum);
6565

66+
EXPORT_TRACEPOINT_SYMBOL_GPL(udp_fail_queue_rcv_skb);
67+
6668
EXPORT_TRACEPOINT_SYMBOL_GPL(sk_data_ready);

net/ipv6/udp.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
#include <net/tcp_states.h>
4646
#include <net/ip6_checksum.h>
4747
#include <net/ip6_tunnel.h>
48+
#include <trace/events/udp.h>
4849
#include <net/xfrm.h>
4950
#include <net/inet_hashtables.h>
5051
#include <net/inet6_hashtables.h>
@@ -680,6 +681,7 @@ static int __udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
680681
}
681682
UDP6_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
682683
kfree_skb_reason(skb, drop_reason);
684+
trace_udp_fail_queue_rcv_skb(rc, sk);
683685
return -1;
684686
}
685687

0 commit comments

Comments
 (0)