Skip to content

Commit b0c7663

Browse files
committed
Merge branch 'selftests/bpf: Fixes for perf_buffer test'
Jiri Olsa says: ==================== hi, sending fixes for perf_buffer test on systems with offline cpus. v2: - resend due to delivery issues, no changes thanks, jirka Acked-by: John Fastabend <[email protected]> ==================== Signed-off-by: Andrii Nakryiko <[email protected]>
2 parents 8082b85 + 99d0997 commit b0c7663

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

tools/testing/selftests/bpf/prog_tests/perf_buffer.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ int trigger_on_cpu(int cpu)
4545

4646
void serial_test_perf_buffer(void)
4747
{
48-
int err, on_len, nr_on_cpus = 0, nr_cpus, i;
48+
int err, on_len, nr_on_cpus = 0, nr_cpus, i, j;
4949
struct perf_buffer_opts pb_opts = {};
5050
struct test_perf_buffer *skel;
5151
cpu_set_t cpu_seen;
@@ -107,32 +107,33 @@ void serial_test_perf_buffer(void)
107107
"expect %d, seen %d\n", nr_on_cpus, CPU_COUNT(&cpu_seen)))
108108
goto out_free_pb;
109109

110-
if (CHECK(perf_buffer__buffer_cnt(pb) != nr_cpus, "buf_cnt",
111-
"got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_cpus))
110+
if (CHECK(perf_buffer__buffer_cnt(pb) != nr_on_cpus, "buf_cnt",
111+
"got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_on_cpus))
112112
goto out_close;
113113

114-
for (i = 0; i < nr_cpus; i++) {
114+
for (i = 0, j = 0; i < nr_cpus; i++) {
115115
if (i >= on_len || !online[i])
116116
continue;
117117

118-
fd = perf_buffer__buffer_fd(pb, i);
118+
fd = perf_buffer__buffer_fd(pb, j);
119119
CHECK(fd < 0 || last_fd == fd, "fd_check", "last fd %d == fd %d\n", last_fd, fd);
120120
last_fd = fd;
121121

122-
err = perf_buffer__consume_buffer(pb, i);
122+
err = perf_buffer__consume_buffer(pb, j);
123123
if (CHECK(err, "drain_buf", "cpu %d, err %d\n", i, err))
124124
goto out_close;
125125

126126
CPU_CLR(i, &cpu_seen);
127127
if (trigger_on_cpu(i))
128128
goto out_close;
129129

130-
err = perf_buffer__consume_buffer(pb, i);
131-
if (CHECK(err, "consume_buf", "cpu %d, err %d\n", i, err))
130+
err = perf_buffer__consume_buffer(pb, j);
131+
if (CHECK(err, "consume_buf", "cpu %d, err %d\n", j, err))
132132
goto out_close;
133133

134134
if (CHECK(!CPU_ISSET(i, &cpu_seen), "cpu_seen", "cpu %d not seen\n", i))
135135
goto out_close;
136+
j++;
136137
}
137138

138139
out_free_pb:

tools/testing/selftests/bpf/progs/test_perf_buffer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ struct {
1212
__type(value, int);
1313
} perf_buf_map SEC(".maps");
1414

15-
SEC("tp/raw_syscalls/sys_enter")
15+
SEC("tp/syscalls/sys_enter_nanosleep")
1616
int handle_sys_enter(void *ctx)
1717
{
1818
int cpu = bpf_get_smp_processor_id();

0 commit comments

Comments
 (0)