Skip to content

Commit 720e5c0

Browse files
Venkateswara NaralasettyKalle Valo
authored andcommitted
ath10k: provide survey info as accumulated data
It is expected that the returned counters by .get_survey are monotonic increasing. But the data from ath10k gets reset to zero regularly. Channel active/busy time are then showing incorrect values (less than previous or sometimes zero) for the currently active channel during successive survey dump commands. example: $ iw dev wlan0 survey dump Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 54995 ms channel busy time: 432 ms channel receive time: 0 ms channel transmit time: 59 ms ... $ iw dev wlan0 survey dump Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 32592 ms channel busy time: 254 ms channel receive time: 0 ms channel transmit time: 0 ms ... The correct way to handle this is to use the non-clearing WMI_BSS_SURVEY_REQ_TYPE_READ wmi_bss_survey_req_type. The firmware will then accumulate the survey data and handle wrap arounds. Tested-on: QCA9984 hw1.0 10.4-3.5.3-00057 Tested-on: QCA988X hw2.0 10.2.4-1.0-00047 Tested-on: QCA9888 hw2.0 10.4-3.9.0.2-00024 Tested-on: QCA4019 hw1.0 10.4-3.6-00140 Fixes: fa7937e ("ath10k: update bss channel survey information") Signed-off-by: Venkateswara Naralasetty <[email protected]> Tested-by: Markus Theil <[email protected]> Tested-by: John Deere <[email protected]> [[email protected]: adjust commit message] Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 67b927f commit 720e5c0

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/ath/ath10k

1 file changed

+1
-1
lines changed

drivers/net/wireless/ath/ath10k/mac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7283,7 +7283,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar,
72837283
struct ieee80211_channel *channel)
72847284
{
72857285
int ret;
7286-
enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
7286+
enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
72877287

72887288
lockdep_assert_held(&ar->conf_mutex);
72897289

0 commit comments

Comments
 (0)