Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Commit 7275a7e

Browse files
committed
Merge branch 'mlxsw-Few-small-fixes'
Ido Schimmel says: ==================== mlxsw: Few small fixes Patch #1, from Petr, adjusts mlxsw to provide the same QoS behavior for both Spectrum-1 and Spectrum-2. The fix is required due to a difference in the behavior of Spectrum-2 compared to Spectrum-1. The problem and solution are described in the detail in the changelog. Patch #2 increases the time period in which the driver waits for the firmware to signal it has finished its initialization. The issue will be fixed in future firmware versions and the timeout will be decreased. Patch #3, from Amit, fixes a display problem where the autoneg status in ethtool is not updated in case the netdev is not running. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 27b141f + 151f0dd commit 7275a7e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

drivers/net/ethernet/mellanox/mlxsw/pci_hw.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
#define MLXSW_PCI_SW_RESET 0xF0010
2929
#define MLXSW_PCI_SW_RESET_RST_BIT BIT(0)
30-
#define MLXSW_PCI_SW_RESET_TIMEOUT_MSECS 13000
30+
#define MLXSW_PCI_SW_RESET_TIMEOUT_MSECS 20000
3131
#define MLXSW_PCI_SW_RESET_WAIT_MSECS 100
3232
#define MLXSW_PCI_FW_READY 0xA1844
3333
#define MLXSW_PCI_FW_READY_MASK 0xFFFF

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3126,11 +3126,11 @@ mlxsw_sp_port_set_link_ksettings(struct net_device *dev,
31263126
if (err)
31273127
return err;
31283128

3129+
mlxsw_sp_port->link.autoneg = autoneg;
3130+
31293131
if (!netif_running(dev))
31303132
return 0;
31313133

3132-
mlxsw_sp_port->link.autoneg = autoneg;
3133-
31343134
mlxsw_sp_port_admin_status_set(mlxsw_sp_port, false);
31353135
mlxsw_sp_port_admin_status_set(mlxsw_sp_port, true);
31363136

@@ -3316,7 +3316,7 @@ static int mlxsw_sp_port_ets_init(struct mlxsw_sp_port *mlxsw_sp_port)
33163316
err = mlxsw_sp_port_ets_set(mlxsw_sp_port,
33173317
MLXSW_REG_QEEC_HIERARCY_TC,
33183318
i + 8, i,
3319-
false, 0);
3319+
true, 100);
33203320
if (err)
33213321
return err;
33223322
}

0 commit comments

Comments
 (0)