Skip to content

Commit 9fd6c1c

Browse files
panagosg7Vilém Jeniš
authored andcommitted
v0.115 remove unused suppressions
Summary: removed unused suppressions ``` ~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www ~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/mobile ~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/service_workers ~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/bladerunner ``` reverted generated files ``` hg status -n | xargs grep -P -l '@(partially-)?generated' | xargs hg revert -r . ``` prettified ``` hg status -n | xargs grep -l 'format' | xargs -P 20 -n 1000 prettier --write ``` reverted changes due to lingering Flow errors ``` html/js/bladerunner/lib/live_feed/fetch_experiment/GraphQLBatchRequest.js html/shared/ads/types/AdsDraftPublishRealtimeTypes.js html/shared/banzai/BanzaiLooper.js html/shared/draft-js/component/base/DraftEditor.react.js html/shared/modules/BigPipe.js html/shared/modules/ReactRenderer.js ``` drop-conflicts Reviewed By: dsainati1 Differential Revision: D19290448 fbshipit-source-id: cfdaefb8b5244483192e93d9edf8649a2900d2c5
1 parent 8f7231d commit 9fd6c1c

File tree

4 files changed

+0
-19
lines changed

4 files changed

+0
-19
lines changed

src/component/base/DraftEditor.react.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -302,12 +302,6 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
302302
accessibilityID: this._placeholderAccessibilityID,
303303
};
304304

305-
/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
306-
* found when Flow v0.112 was deployed. To see the error delete this
307-
* comment and run Flow. */
308-
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error found
309-
* when Flow v0.112 was deployed. To see the error delete this comment
310-
* and run Flow. */
311305
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an error
312306
* found when Flow v0.112 was deployed. To see the error delete this
313307
* comment and run Flow. */

src/component/contents/DraftEditorContents-core.react.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,6 @@ class DraftEditorContents extends React.Component<Props> {
224224
const child = React.createElement(
225225
Element,
226226
childProps,
227-
/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
228-
* found when Flow v0.112 was deployed. To see the error delete this
229-
* comment and run Flow. */
230-
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error
231-
* found when Flow v0.112 was deployed. To see the error delete this
232-
* comment and run Flow. */
233227
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an
234228
* error found when Flow v0.112 was deployed. To see the error delete
235229
* this comment and run Flow. */

src/component/contents/exploration/DraftEditorContentsExperimental.react.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,6 @@ class DraftEditorContentsExperimental extends React.Component<Props> {
146146
blockRenderMap.get('unstyled');
147147
const wrapperTemplate = configForType.wrapper;
148148
processedBlocks.push({
149-
/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
150-
* found when Flow v0.112 was deployed. To see the error delete this
151-
* comment and run Flow. */
152-
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error
153-
* found when Flow v0.112 was deployed. To see the error delete this
154-
* comment and run Flow. */
155149
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an
156150
* error found when Flow v0.112 was deployed. To see the error delete
157151
* this comment and run Flow. */

src/component/utils/isInstanceOfNode.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ function isInstanceOfNode(target: ?EventTarget): boolean {
1919
if (!node.ownerDocument.defaultView) {
2020
return node instanceof Node;
2121
}
22-
// $FlowFixMe https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11508#issuecomment-256045682
2322
if (node instanceof node.ownerDocument.defaultView.Node) {
2423
return true;
2524
}

0 commit comments

Comments
 (0)