always use unique name for volume and snapshot #476

huww98 · 2023-08-08T10:06:29Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Always add random chars to name.

This would avoid any name conflicts. And matches k8s behaviour better.

Some system does not work if the same name is reused even after the previous resource is deleted. The idempotent state may not be cleared when resource deleted.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2023-08-08T10:06:37Z

Welcome @huww98!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-08-08T10:06:37Z

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msau42 · 2023-08-16T15:59:25Z

/ok-to-test

k8s-triage-robot · 2024-01-21T02:11:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-20T02:25:15Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

huww98 · 2024-02-20T03:49:58Z

I think this PR is still relevant. @msau42 @gnufied @RaunakShah PTAL~.

xing-yang · 2024-03-07T16:10:52Z

pkg/sanity/sanity.go

+func UniqueStringWithLength(prefix string, length int) string {
+	str := UniqueString(prefix)
+	if len(str) > length {
+		Panic()


Do we have to introduce Panic() here? Can we trim it if it is longer than "length" and make it a best effort to have a unique name?

I think we'd better panic here, and make it guaranteed unique. All callers are just using a hard-coded prefix, So if someone do reach here, it should be easy for him to just fix the panic by using a shorter prefix, rather than debugging weird issue caused by non-unique ID.

I mean panic() rather than Panic() here, I'll fix that.

xing-yang · 2024-03-07T16:12:05Z

/remove-lifecycle stale

xing-yang · 2024-03-07T16:12:37Z

/remove-lifecycle rotten

Always add random chars to name. This would avoid any name conflicts. And matches k8s behaviour better. Some system does not work if the same name is reused even after the previous resource is deleted. The idempotent state may not be cleared when resource deleted.

xing-yang · 2024-03-07T18:21:23Z

/lgtm
/approve

k8s-ci-robot · 2024-03-07T18:21:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from RaunakShah and gnufied August 8, 2023 10:06

huww98 force-pushed the uniq-name branch 2 times, most recently from 6959b55 to d24c5c5 Compare August 11, 2023 07:23

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 20, 2024

xing-yang reviewed Mar 7, 2024

View reviewed changes

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 7, 2024

huww98 force-pushed the uniq-name branch from d24c5c5 to 06d53d8 Compare March 7, 2024 17:20

k8s-ci-robot assigned xing-yang Mar 7, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024

k8s-ci-robot merged commit 015fa98 into kubernetes-csi:master Mar 7, 2024

huww98 mentioned this pull request Dec 7, 2024

use unique name for volume #566

Merged

always use unique name for volume and snapshot #476

always use unique name for volume and snapshot #476

Uh oh!

Conversation

huww98 commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 8, 2023

Uh oh!

k8s-ci-robot commented Aug 8, 2023

Uh oh!

msau42 commented Aug 16, 2023

Uh oh!

k8s-triage-robot commented Jan 21, 2024

Uh oh!

k8s-triage-robot commented Feb 20, 2024

Uh oh!

huww98 commented Feb 20, 2024

Uh oh!

xing-yang Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

huww98 Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

xing-yang commented Mar 7, 2024

Uh oh!

xing-yang commented Mar 7, 2024

Uh oh!

xing-yang commented Mar 7, 2024

Uh oh!

k8s-ci-robot commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huww98 commented Aug 8, 2023 •

edited

Loading