Apply feedback

Author: jpbetz

value/list.go

@@ -29,7 +29,7 @@ type List interface {
 	// Equals compares the two list, and return true if they are the same, false otherwise.
 	// Implementations can use ListEquals as a general implementation for this methods.
 	Equals(List) bool
-	// Recycle returns a value of this type that is no longer needed. The
+	// Recycle gives back this List once it is no longer needed. The
 	// value shouldn't be used after this call.
 	Recycle()
 }
@@ -43,7 +43,7 @@ type ListRange interface {
 	// pointers to the value returned by Item() that escape the iteration loop since they become invalid once either
 	// Item() or Recycle() is called.
 	Item() (index int, value Value)
-	// Recycle returns a ListRange that is no longer needed. The value returned by Item() becomes invalid once this is
+	// Recycle gives back this ListRange once it is no longer needed. The value returned by Item() becomes invalid once this is
 	// called.
 	Recycle()
 }

value/map.go

@@ -45,7 +45,7 @@ type Map interface {
 	// with the values from both maps, otherwise it is called with the value of the map that contains the key and nil
 	// for the map that does not contain the key. Returning false in the closure prematurely stops the iteration.
 	Zip(other Map, order MapTraverseOrder, fn func(key string, lhs, rhs Value) bool) bool
-	// Recycle returns a value of this type that is no longer needed. The
+	// Recycle gives back this Map once it is no longer needed. The
 	// value shouldn't be used after this call.
 	Recycle()
 }
@@ -121,17 +121,22 @@ func unorderedMapZip(lhs, rhs Map, fn func(key string, lhs, rhs Value) bool) boo
 
 func lexicalKeyOrderedMapZip(lhs, rhs Map, fn func(key string, lhs, rhs Value) bool) bool {
 	var lhsLength, rhsLength int
+	var orderedLength int // rough estimate of length of union of map keys
 	if lhs != nil {
 		lhsLength = lhs.Length()
+		orderedLength = lhsLength
 	}
 	if rhs != nil {
 		rhsLength = rhs.Length()
+		if rhsLength > orderedLength {
+			orderedLength = rhsLength
+		}
 	}
 	if lhsLength == 0 && rhsLength == 0 {
 		return true
 	}
 
-	ordered := make([]string, 0, lhsLength+rhsLength)
+	ordered := make([]string, 0, orderedLength)
 	if lhs != nil {
 		lhs.Iterate(func(key string, _ Value) bool {
 			ordered = append(ordered, key)

value/value.go

@@ -71,7 +71,7 @@ type Value interface {
 	// doesn't allow it).
 	AsString() string
 
-	// Recycle returns a value of this type that is no longer needed. The
+	// Recycle gives back this Value once it is no longer needed. The
 	// value shouldn't be used after this call.
 	Recycle()