Skip to content

[cluster-autoscaler-release-1.32] Replace autorest/to with k8s.io/utils/ptr #8732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: cluster-autoscaler-release-1.32
Choose a base branch
from
Open

[cluster-autoscaler-release-1.32] Replace autorest/to with k8s.io/utils/ptr #8732

wants to merge 1 commit into from
+155 −158

Conversation

@jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

This is a manual cherry pick of #8723

Credit to @mboersma

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n October 31, 2025 22:14
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider and removed do-not-merge/needs-area labels Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2025
@jackfrancis
Copy link
Contributor Author

/retitle [cluster-autoscaler-release-1.32] Replace autorest/to with k8s.io/utils/ptr

@k8s-ci-robot k8s-ci-robot changed the title Replace autorest/to with k8s.io/utils/ptr [cluster-autoscaler-release-1.32] Replace autorest/to with k8s.io/utils/ptr Oct 31, 2025
@jackfrancis
Copy link
Contributor Author

/assign @mboersma

@jackfrancis
Copy link
Contributor Author

/release-note-note

@jackfrancis jackfrancis removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackfrancis @k8s-ci-robot @mboersma