@@ -578,26 +578,35 @@ The list of current valid types is
578578
579579### Test Plan
580580
581- #### Unit Tests and Benchmarks
581+ [X] I/we understand the owners of the involved components may require updates to
582+ existing tests to make this code solid enough prior to committing the changes necessary
583+ to implement this enhancement.
582584
583- - Ensure that the controller scales to ~5,000 nodes -- memory usage and
584- reasonable allocation times
585+ ##### Prerequisite testing updates
585586
586- #### Integration Tests
587+ N/A
588+
589+ ##### Unit tests
590+
591+ - Ensure that the controller scales to ~5,000 nodes -- memory usage and
592+ reasonable allocation times.
593+ - k8s.io/kubernetes/pkg/controller/nodeipam: 06/21/2022 - 51.2
594+
595+ ##### Integration tests
587596
588597- Verify finalizers and statuses are persisted appropriately
589598- Test watchers
590599- Ensure that the controller handles the feature being disabled and re-enabled:
591600 - Test with some Nodes already having `PodCIDR` allocations
592601
593- #### End-to-End Tests
602+ ##### e2e tests
594603
595604- Run through some sample workflows. Just a few for example:
596605 - Adding a node
597606 - Adding a ClusterCIDRConfig
598607 - Deleting a ClusterCIDRConfig that is in use
599608- Run through the [user stories](#user-stories):
600- - Expand the ClusterCIDR (existing nodes without alloations are
609+ - Expand the ClusterCIDR (existing nodes without allocations are
601610 allocated and new nodes also get ranges.
602611 - Use `NodeSelector` to allocate different sized CIDRs to different nodes.
603612 - Create and use discontiguous ranges.
0 commit comments