Skip to content

Commit 8ce2edf

Browse files
committed
Address comments
1 parent b64b3bf commit 8ce2edf

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ fully GA-ed it's time to satisfy the original request.
8282

8383
### Goals
8484

85-
- Add the field `.spec.timeZone` which allows specifying a valid TimeZone
85+
- Add the field `.spec.timeZone` which allows specifying a valid TimeZone name
8686

8787
### Non-Goals
8888

@@ -95,7 +95,7 @@ and make progress.
9595

9696
Add the field `.spec.timeZone` to the CronJob resource. The cronjob controller
9797
will take the field into account when scheduling the next Job run. In case the
98-
field is not specified or is empty the controller will maitain the current
98+
field is not specified or is empty the controller will maintain the current
9999
behavior which is to rely on the time zone of the kube-controller-manager
100100
process.
101101

@@ -125,20 +125,22 @@ CronJobs can be created per user.
125125

126126
### CronJob API
127127

128-
The `CronJobSpec` structure is expanded with new `TimeZone` field which allows
128+
The `.spec` for a CronJob is expanded with new `timeZone` field which allows
129129
specifying the name of the time zone to be used. Missing or empty value of the
130130
field indicates the current behavior, which relies on the time zone of the
131131
kube-controller-manager process.
132132

133+
In the API code, that looks like:
134+
133135
```golang
134136

135137
type CronJobSpec struct {
136138

137-
// The schedule in Cron format, see https://en.wikipedia.org/wiki/Cron.
138-
Schedule string
139+
// The schedule in Cron format, see https://en.wikipedia.org/wiki/Cron.
140+
Schedule string
139141

140-
// Time zone for the above schedule
141-
TimeZone *string
142+
// Time zone for the above schedule
143+
TimeZone *string
142144

143145
}
144146
```
@@ -489,6 +491,9 @@ Why should this KEP _not_ be implemented?
489491

490492
## Alternatives
491493

494+
Another approach was to specify time zone as an offset to UTC, but using the
495+
name instead seems more user friendly.
496+
492497
<!--
493498
What other approaches did you consider, and why did you rule them out? These do
494499
not need to be as detailed as the proposal, but should include enough

keps/sig-apps/3140-TimeZone-support-in-CronJob/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ status: implementable
88
creation-date: 2022-01-14
99
reviewers:
1010
- "@ravig"
11+
- "@atiratree"
1112
- "@iterion"
1213
approvers:
1314
- "@janetkuo"
@@ -41,4 +42,4 @@ disable-supported: true
4142

4243
# The following PRR answers are required at beta release
4344
metrics:
44-
- my_feature_metric
45+
# - my_feature_metric

0 commit comments

Comments
 (0)