Skip to content

Commit ab98036

Browse files
committed
remarks
1 parent 208d826 commit ab98036

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-apps/3329-retriable-and-non-retriable-failures

1 file changed

+4
-3
lines changed

keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -637,8 +637,8 @@ defined in the k8s.io/apis/core/v1 package. Thus, every addition of a new
637637
condition type will require an API review. The constants will allow users of the
638638
package to reduce the risk of typing mistakes.
639639

640-
Additionally, for Beta, we will re-evaluate an idea of a generic condition
641-
type indicating that a pod can be retried, for example `Retriable`.
640+
Additionally, for Beta, we will re-evaluate an idea of a generic opinionated condition
641+
type indicating that a pod can be retried, for example `TerminatedByControlPlane`.
642642

643643
Finally, we are going to cover the handling of pod failures associated with the
644644
new PodCondition types in integration tests.
@@ -671,6 +671,7 @@ condition makes it easier to determine if a failed pod should be restarted):
671671
- EvictedByTaints (Pod evicted by kube-controller-manager due to taints)
672672
- GarbageCollected (an orphaned Pod terminated by GC)
673673
- EvictedByAPI (Pod evicted by Eviction API)
674+
- EvictedFromUnhealthyNode (initiated by the node lifecycle controller)
674675

675676
The already existing `status.conditions` field in Pod will be used by kubernetes
676677
control plane components (kube-scheduler and kube-controller-manager) to append
@@ -999,7 +1000,7 @@ Below are some examples to consider, in addition to the aforementioned [maturity
9991000
- Re-evaluate modification to kubelet to send a dedicated condition when
10001001
terminating a Pod, based on user feedback
10011002
- Re-evaluate supporting of `onExitCodes` when `restartPolicy=OnFailure`
1002-
- Re-evaluate introduction of a generic condition type such as `Retriable`
1003+
- Re-evaluate introduction of a generic opinionated condition type
10031004
indicating that a pod should be retried
10041005
- The feature flag enabled by default
10051006

0 commit comments

Comments
 (0)