Skip to content

Commit ae54106

Browse files
committed
Add CRD conversion webhook to v1beta1 criteria to KEP
1 parent 130460d commit ae54106

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

keps/sig-api-machinery/20190425-crd-conversion-webhook.md

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@ authors:
66
owning-sig: sig-api-machinery
77
participating-sigs:
88
reviewers:
9-
- "@dbsmith"
9+
- "@lavalamp"
1010
- "@deads2k"
1111
- "@sttts"
1212
- "@liggit"
13-
- "@enisoc"
1413
approvers:
15-
- "@dbsmith"
14+
- "@lavalamp"
1615
- "@deads2k"
1716
creation-date: 2019-04-25
1817
last-updated: 2019-04-25
@@ -736,8 +735,23 @@ Consider including folks that also work outside the SIG or subproject.
736735
737736
## Graduation Criteria
738737
738+
v1beta1:
739739
740740
741+
- Ensure the scenarios from (https://github.com/kubernetes/kubernetes/issues/64136) are tested:
742+
- Ensure what is persisted in etcd matches the storage version
743+
- Set up a CRD, persist some data, change the storage version, and ensure the previously persisted data is readable
744+
- Ensure discovery docs track a CRD through creation, version addition, version removal, and deletion
745+
- Ensure `spec.served` is respected
746+
747+
v1:
748+
749+
- ConversionReview API v1 is stable (including fields that need to be updated for v1beta1 or v1)
750+
- Documented step-by-step CRD version migration workflow that covers the entire
751+
process of migrating from one version to another (introduce a new CRD version,
752+
add the converter, migrate clients, migrate to new storage version, all the
753+
way to removing the old version)
754+
741755
## Implementation History
742756
743757
- Implemented in Kubernetes 1.13 release (https://github.com/kubernetes/kubernetes/pull/67006)

0 commit comments

Comments
 (0)