[Enhancement] Add functional test for scp command

- skip tests for windows os
Signed-off-by: anencore94 <[email protected]>

Author: anencore94

cmd/minikube/cmd/scp.go

@@ -22,12 +22,14 @@ import (
 	"path/filepath"
 
 	"github.com/spf13/cobra"
+
 	"k8s.io/minikube/pkg/minikube/config"
 	"k8s.io/minikube/pkg/minikube/exit"
 	"k8s.io/minikube/pkg/minikube/localpath"
 	"k8s.io/minikube/pkg/minikube/mustload"
 	"k8s.io/minikube/pkg/minikube/node"
 	"k8s.io/minikube/pkg/minikube/out"
+
 	"k8s.io/minikube/pkg/minikube/reason"
 )
 
@@ -45,7 +47,7 @@ var (
 var scpCmd = &cobra.Command{
 	Use:   "scp [flags] <source file or directory path> <target file or directory path followed by '/home/docker/'>",
 	Short: "Copy the specified file or directory into minikube",
-	Long:  "Copy the specified file or directory into minikube, it will be saved at path \"/home/docker/<target file or directory path>\" in your minikube.\n" +
+	Long: "Copy the specified file or directory into minikube, it will be saved at path \"/home/docker/<target file or directory path>\" in your minikube.\n" +
 		"Example Command : \"minikube scp a.txt b.txt\"\n",
 	Run: func(cmd *cobra.Command, args []string) {
 		// validate args

site/content/en/docs/commands/scp.md

@@ -36,6 +36,7 @@ minikube scp [flags] <source file or directory path> <target file or directory p
       --skip_headers                     If true, avoid header prefixes in the log messages
       --skip_log_headers                 If true, avoid headers when opening log files
       --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
+      --user string                      Specifies the user executing the operation. Useful for auditing operations executed by 3rd party tools. Defaults to the operating system username.
   -v, --v Level                          number for the log level verbosity
       --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
 ```

test/integration/functional_test.go

@@ -121,6 +121,7 @@ func TestFunctional(t *testing.T) {
 			{"PersistentVolumeClaim", validatePersistentVolumeClaim},
 			{"TunnelCmd", validateTunnelCmd},
 			{"SSHCmd", validateSSHCmd},
+			{"ScpCmd", validateScpCmd},
 			{"MySQL", validateMySQL},
 			{"FileSync", validateFileSync},
 			{"CertSync", validateCertSync},
@@ -1117,6 +1118,37 @@ func validateSSHCmd(ctx context.Context, t *testing.T, profile string) {
 	}
 }
 
+// validateScpCmd asserts basic "scp" command functionality
+func validateScpCmd(ctx context.Context, t *testing.T, profile string) {
+	if windowsPlatform() {
+		t.Skipf("skipping: scp is unsupported by windows os")
+	}
+	if NoneDriver() {
+		t.Skipf("skipping: scp is unsupported by none driver")
+	}
+
+	scpPath := filepath.Join(*testdataDir, "scp-test.txt")
+	rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "scp", scpPath, "hello_scp.txt"))
+	if ctx.Err() == context.DeadlineExceeded {
+		t.Errorf("failed to run command by deadline. exceeded timeout : %s", rr.Command())
+	}
+	if err != nil {
+		t.Errorf("failed to run an scp command. args %q : %v", rr.Command(), err)
+	}
+
+	expected := "Test file for checking file scp process"
+	rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "cat hello_scp.txt"))
+	if ctx.Err() == context.DeadlineExceeded {
+		t.Errorf("failed to run command by deadline. exceeded timeout : %s", rr.Command())
+	}
+	if err != nil {
+		t.Errorf("failed to run an scp command. args %q : %v", rr.Command(), err)
+	}
+	if diff := cmp.Diff(expected, rr.Stdout.String()); diff != "" {
+		t.Errorf("/testdata/scp-test.txt content mismatch (-want +got):\n%s", diff)
+	}
+}
+
 // validateMySQL validates a minimalist MySQL deployment
 func validateMySQL(ctx context.Context, t *testing.T, profile string) {
 	if arm64Platform() {

test/integration/main_test.go

@@ -157,6 +157,11 @@ func arm64Platform() bool {
 	return runtime.GOARCH == "arm64"
 }
 
+// windowsPlatform returns true if running on windows platform
+func windowsPlatform() bool {
+	return runtime.GOARCH == "windows"
+}
+
 // NeedsPortForward returns access to endpoints with this driver needs port forwarding
 // (Docker on non-Linux platforms requires ports to be forwarded to 127.0.0.1)
 func NeedsPortForward() bool {

test/integration/testdata/scp-test.txt

@@ -0,0 +1 @@
+Test file for checking file scp process