Fix long lines in lastStart.txt not outputting in log outputs

spowelljr · spowelljr · commit efb7b2e4a428 · 2024-10-01T15:04:44.000-07:00
diff --git a/pkg/minikube/logs/logs.go b/pkg/minikube/logs/logs.go
@@ -234,15 +234,17 @@ func OutputLastStart() error {
 	}
 	defer f.Close()
 	l := ""
-	s := bufio.NewScanner(f)
-	for s.Scan() {
-		l += s.Text() + "\n"
+	r := bufio.NewReader(f)
+	var s string
+	for s, err = r.ReadString('\n'); err != nil; {
+		l += s + "\n"
 	}
 	out.Styled(style.None, l)
-	if err := s.Err(); err != nil {
-		return fmt.Errorf("failed to read file %s: %v", fp, err)
+	if err == io.EOF {
+		return nil
 	}
-	return nil
+
+	return fmt.Errorf("failed to read file %s: %v", fp, err)
 }
 
 // OutputOffline outputs logs that don't need a running cluster.

Original file line number	Diff line number	Diff line change
`@@ -234,15 +234,17 @@ func OutputLastStart() error {`
`234`	`234`	`}`
`235`	`235`	`defer f.Close()`
`236`	`236`	`l := ""`
`237`		`- s := bufio.NewScanner(f)`
`238`		`- for s.Scan() {`
`239`		`- l += s.Text() + "\n"`
	`237`	`+ r := bufio.NewReader(f)`
	`238`	`+ var s string`
	`239`	`+ for s, err = r.ReadString('\n'); err != nil; {`
	`240`	`+ l += s + "\n"`
`240`	`241`	`}`
`241`	`242`	`out.Styled(style.None, l)`
`242`		`- if err := s.Err(); err != nil {`
`243`		`- return fmt.Errorf("failed to read file %s: %v", fp, err)`
	`243`	`+ if err == io.EOF {`
	`244`	`+ return nil`
`244`	`245`	`}`
`245`		`- return nil`
	`246`	`+`
	`247`	`+ return fmt.Errorf("failed to read file %s: %v", fp, err)`
`246`	`248`	`}`
`247`	`249`
`248`	`250`	`// OutputOffline outputs logs that don't need a running cluster.`