Wait for the CRI socket to be created properly #10356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before returning the container runtime back to the caller. Wait for a minute (usually 1 second) Note that this doesn't apply to the dockershim, it only replies to runtimes that are using CRI.
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver Times for Minikube (PR 10356): 67.0s 64.4s 67.5s Averages Time Per Log docker Driver Times for Minikube (PR 10356): 26.7s 25.5s 25.6s Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before returning the container runtime back to
the caller. Wait for a minute (usually 1 second)
Note that this doesn't apply to the dockershim,
it only replies to runtimes that are using CRI.
The
systemctl restart containerdcompletes right away, before the service is up and running properly.This makes all
crictlfail, later on. Instead wait for the CRI socket to get created, before continuing to use it.Sample output, after this fix:
It can be an issue for large installations, where it takes a while to start up the container runtime.
Note that this doesn't apply to Docker, it only applies to CRI and not to the kubelet dockershim.
EDIT: Actually it will apply to Docker too in the future, when it starts using CRI: #9868
Closes #10355