Skip to content

Conversation

@lilongfeng0902
Copy link

I find unuseful infos when I use minikube on windows platform. I suggest to remove the info about 'minikube image build'.

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lilongfeng0902. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lilongfeng0902
To complete the pull request process, please assign tstromberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Apr 2, 2021

I find unuseful infos when I use minikube on windows platform. I suggest to remove the info about 'minikube image build'.

I think @medyagh merged the documentation about the new commands, ahead of the actual command itself: PR #10742

In #10819 (labelled do-not-merge)

But it is more "premature" than "unuseful".

See https://deploy-preview-10742--kubernetes-sigs-minikube.netlify.app/docs/commands/image/#minikube-image-build

@lilongfeng0902
Copy link
Author

I find unuseful infos when I use minikube on windows platform. I suggest to remove the info about 'minikube image build'.

I think @medyagh merged the documentation about the new commands, ahead of the actual command itself: PR #10742

In #10819 (labelled do-not-merge)

But it is more "premature" than "unuseful".

See https://deploy-preview-10742--kubernetes-sigs-minikube.netlify.app/docs/commands/image/#minikube-image-build

Yeah, now, I know that why i'm confusing about "minikube image build", it is "premature". I hope that PR #10742 will be merged soon, then I glad to use the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants