From 51610bcb4030010c42e994a5dfa0c2b02e4dd273 Mon Sep 17 00:00:00 2001
From: Nir Soffer <nirsof@gmail.com>
Date: Sat, 17 Feb 2024 18:51:32 +0200
Subject: [PATCH] kvm2 driver: Remove uneeded nvram element

The curent domain xml template includes static nvram image using the
shared template image:

    <nvram>/usr/share/AAVMF/AAVMF_VARS.fd</nvram>

This "works" when starting sinlge profile, but when starting a second
profile this breaks with:

    virError(Code=55, Domain=24, Message='Requested operation is not
    valid: Setting different SELinux label on /usr/share/AAVMF/AAVMF_VARS.fd
    which is already in use

Which tells us that we are doing the wrong thing.

If we remove the nvram element, a new per-vm nvram is created
dynamially:

    $ virsh -c qemu:///system dumpxml ex1 | grep nvram
    <nvram template='/usr/share/AAVMF/AAVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/ex1_VARS.fd</nvram>

    $ virsh -c qemu:///system dumpxml ex2 | grep nvram
    <nvram template='/usr/share/AAVMF/AAVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/ex2_VARS.fd</nvram>
---
 pkg/drivers/kvm/domain_definition_arm64.go | 1 -
 1 file changed, 1 deletion(-)

diff --git a/pkg/drivers/kvm/domain_definition_arm64.go b/pkg/drivers/kvm/domain_definition_arm64.go
index 85082457f712..477914913af0 100644
--- a/pkg/drivers/kvm/domain_definition_arm64.go
+++ b/pkg/drivers/kvm/domain_definition_arm64.go
@@ -41,7 +41,6 @@ const domainTmpl = `
   <os>
     <type machine='virt-4.2' arch='aarch64'>hvm</type>
     <loader readonly='yes' type='pflash'>/usr/share/AAVMF/AAVMF_CODE.fd</loader>
-    <nvram>/usr/share/AAVMF/AAVMF_VARS.fd</nvram>
     <boot dev='cdrom'/>
     <boot dev='hd'/>
     <bootmenu enable='no'/>