Merge pull request #84 from kuzzleio/fix-rc-73-paginate-fetchAll

fixed #73

Author: scottinet

src/kuzzleDataCollection.js

@@ -346,14 +346,27 @@ KuzzleDataCollection.prototype.fetchDocument = function (documentId, options, cb
  * @returns {Object} this
  */
 KuzzleDataCollection.prototype.fetchAllDocuments = function (options, cb) {
+  var filters = {};
+
   if (!cb && typeof options === 'function') {
     cb = options;
     options = null;
   }
 
+  // copying pagination options to the search filter
+  if (options) {
+    if (options.from) {
+      filters.from = options.from;
+    }
+
+    if (options.size) {
+      filters.size = options.size;
+    }
+  }
+
   this.kuzzle.callbackRequired('KuzzleDataCollection.fetchAll', cb);
 
-  this.advancedSearch({}, options, cb);
+  this.advancedSearch(filters, options, cb);
 
   return this;
 };

test/kuzzleDataCollection/methods.test.js

@@ -1,6 +1,7 @@
 var
   should = require('should'),
   rewire = require('rewire'),
+  sinon = require('sinon'),
   proxyquire = require('proxyquire'),
   Kuzzle = rewire('../../src/kuzzle'),
   KuzzleDataCollection = rewire('../../src/kuzzleDataCollection'),
@@ -539,6 +540,17 @@ describe('KuzzleDataCollection methods', function () {
       collection.fetchAllDocuments({}, function () {});
       should(emitted).be.true();
     });
+
+    it('should handle the from and size options', () => {
+      var
+        collection = kuzzle.dataCollectionFactory(expectedQuery.collection),
+        stub = sinon.stub(collection, 'advancedSearch');
+
+      collection.fetchAllDocuments({from: 123, size: 456}, function () {});
+      should(stub.calledOnce).be.true();
+      should(stub.calledWithMatch({from: 123, size: 456})).be.true();
+      stub.restore();
+    });
   });
 
   describe('#getMapping', function () {