Skip to content

Fix incompatibility with ES6 Javascript #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Fix incompatibility with ES6 Javascript #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/proxify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,15 @@ console.log(obj.bar); // throw error
```
*/

const getOptions = options => ({
const getOptions = options => (Object.assign({}, {
name: 'object',
seal: true,
sealGet: false,
deprecated: [],
warnDeprecationOnce: true,
exposeApi: false,
apiNamespace: '__proxy__',
...options
});
apiNamespace: '__proxy__'
}, options));

const getPropertyNames = obj => {
if (!obj) {
Expand Down Expand Up @@ -94,15 +93,15 @@ const proxify = (obj, opts = {}) => {
// eslint-disable-next-line no-console
console.warn(`Warning: ${hash} is deprecated`);
};

if (options.exposeApi) {
obj[options.apiNamespace] = {
registerProp: name => properties.add(name),
unregisterProp: name => properties.delete(name),
hasProp: name => properties.has(name)
};
}

[
...Object.getOwnPropertyNames(obj),
...getPropertyNames(obj)
Expand All @@ -129,7 +128,7 @@ const proxify = (obj, opts = {}) => {
return true;
}
};

return new Proxy(obj, handler);
};

Expand Down