From 5164db5cf712bdaef48a0f53235b334bba672186 Mon Sep 17 00:00:00 2001 From: madlabman <10616301+madlabman@users.noreply.github.com> Date: Tue, 23 Sep 2025 13:41:19 +0200 Subject: [PATCH 1/2] chore: add fixmes --- scripts/upgrade_tw_csm2.py | 2 +- tests/test_tw_csm2.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/upgrade_tw_csm2.py b/scripts/upgrade_tw_csm2.py index 88f116f6..ea4fef1a 100644 --- a/scripts/upgrade_tw_csm2.py +++ b/scripts/upgrade_tw_csm2.py @@ -78,7 +78,7 @@ # Fixed constants EXIT_EVENTS_LOOKBACK_WINDOW_IN_SLOTS = 14 * 7200 # 14 days in slots (assuming 12 seconds per slot) -NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots +NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots FIXME # VEB parameters MAX_VALIDATORS_PER_REPORT = 600 diff --git a/tests/test_tw_csm2.py b/tests/test_tw_csm2.py index f821a3fa..cf61841d 100644 --- a/tests/test_tw_csm2.py +++ b/tests/test_tw_csm2.py @@ -343,7 +343,7 @@ def check_proxy_implementation(proxy_address, expected_impl): EXIT_EVENTS_LOOKBACK_WINDOW_IN_SLOTS = 14 * 7200 -NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots +NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots FIXME # CSM CS_MODULE_NEW_TARGET_SHARE_BP = 500 # 5% @@ -391,12 +391,12 @@ def check_proxy_implementation(proxy_address, expected_impl): EASYTRACK_CS_SET_VETTED_GATE_TREE_FACTORY = "0xBc5642bDD6F2a54b01A75605aAe9143525D97308" -EXPECTED_VOTE_ID = None +EXPECTED_VOTE_ID = 192 EXPECTED_DG_PROPOSAL_ID = 5 EXPECTED_VOTE_EVENTS_COUNT = 4 EXPECTED_DG_EVENTS_FROM_AGENT = 69 EXPECTED_DG_EVENTS_COUNT = 71 -IPFS_DESCRIPTION_HASH = "bafkreih5app23xbevhswk56r6d2cjdqui5tckki6szo7loi7xe25bfgol4" +IPFS_DESCRIPTION_HASH = "bafkreih5app23xbevhswk56r6d2cjdqui5tckki6szo7loi7xe25bfgol4" # FIXME NETHERMIND_NO_ID = 25 NETHERMIND_NO_NAME_OLD = "Nethermind" From 22c5ef54f970c9bdbead656373990481ac4ce398 Mon Sep 17 00:00:00 2001 From: Nikita P Date: Tue, 23 Sep 2025 12:05:12 +0000 Subject: [PATCH 2/2] fix: IPFS desc & fixme --- scripts/upgrade_tw_csm2.py | 8 ++++++-- tests/test_tw_csm2.py | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/scripts/upgrade_tw_csm2.py b/scripts/upgrade_tw_csm2.py index ea4fef1a..668541d4 100644 --- a/scripts/upgrade_tw_csm2.py +++ b/scripts/upgrade_tw_csm2.py @@ -78,7 +78,7 @@ # Fixed constants EXIT_EVENTS_LOOKBACK_WINDOW_IN_SLOTS = 14 * 7200 # 14 days in slots (assuming 12 seconds per slot) -NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots FIXME +NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots # VEB parameters MAX_VALIDATORS_PER_REPORT = 600 @@ -134,7 +134,11 @@ DSM_QUORUM_SIZE = 4 # ============================= Description ================================== -IPFS_DESCRIPTION = "Triggerable withdrawals and CSM v2 upgrade voting" +IPFS_DESCRIPTION = """ +1. **Upgrade to CSM v2 and increase CSM stake share limit from 3% to 5%**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0xc3f92bcdf8926cfa7528ca6a979c0fdce1e4d0cfaaa72dd6410a76a2e1e55766). Items 1.34-1.59. Audit & deployment verification by: [Statemind](https://github.com/lidofinance/audits/blob/main/Statemind%20Triggerable%20Withdrawals%20and%20CSM%20v2%20Audit%20Report%2009-2025.pdf) | [Ackee](https://github.com/lidofinance/audits/blob/main/Ackee%20Blockchain%20Community%20Staking%20Module%20v2%20Audit%20Report%2009-2025.pdf). +2. **Activate Triggerable Withdrawals**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0x7d7f0e1a6d181310f8752af37e20515a9be258f30b211872f9acca99bc478851). Items 1.1-1.33, 1.60-1.66, 2-4. Audit & deployment verification by [Statemind](https://github.com/lidofinance/audits/blob/main/Statemind%20Triggerable%20Withdrawals%20and%20CSM%20v2%20Audit%20Report%2009-2025.pdf) | Audit by [Ackee](https://github.com/lidofinance/audits/blob/main/Ackee%20Blockchain%20Lido%20Triggerable%20Withdrawals%20Audit%20Report%2009-25.pdf). +3. **Update the reward address and name for Node Operator ID 25 `Nethermind`**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0x3f68e9bc69850da419211c3d9f0a76d006ed044abc0f8bc845bc1d1cf3db0a8d). Items 1.67, 1.68. +4. **Rotate Deposit Security Committee address for `Kiln`**. [Requested on the forum](https://research.lido.fi/t/security-disclosure-kiln-precautionary-out-of-order-exits-in-response-security-incident/10654/3). Items 1.69, 1.70.""" def encode_staking_router_proxy_update(implementation: str) -> Tuple[str, str]: diff --git a/tests/test_tw_csm2.py b/tests/test_tw_csm2.py index cf61841d..a292bec8 100644 --- a/tests/test_tw_csm2.py +++ b/tests/test_tw_csm2.py @@ -343,7 +343,7 @@ def check_proxy_implementation(proxy_address, expected_impl): EXIT_EVENTS_LOOKBACK_WINDOW_IN_SLOTS = 14 * 7200 -NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots FIXME +NOR_EXIT_DEADLINE_IN_SEC = 345600 # 28800 slots # CSM CS_MODULE_NEW_TARGET_SHARE_BP = 500 # 5% @@ -396,7 +396,7 @@ def check_proxy_implementation(proxy_address, expected_impl): EXPECTED_VOTE_EVENTS_COUNT = 4 EXPECTED_DG_EVENTS_FROM_AGENT = 69 EXPECTED_DG_EVENTS_COUNT = 71 -IPFS_DESCRIPTION_HASH = "bafkreih5app23xbevhswk56r6d2cjdqui5tckki6szo7loi7xe25bfgol4" # FIXME +IPFS_DESCRIPTION_HASH = "bafkreicbufoefjutdeadrzhbqnxgonc5rljlwyyrftytxkykiufkpmc3ii" NETHERMIND_NO_ID = 25 NETHERMIND_NO_NAME_OLD = "Nethermind"