Don't show the vnc display password in the log

afbjorklund · afbjorklund · commit 69e56e1076bd · 2023-01-25T08:44:51.000+01:00
Signed-off-by: Anders F Björklund &lt;anders.f.bjorklund@gmail.com&gt;
diff --git a/pkg/hostagent/hostagent.go b/pkg/hostagent/hostagent.go
@@ -303,10 +303,10 @@ func (a *HostAgent) Run(ctx context.Context) error {
 		if err := os.WriteFile(vncfile, []byte(vncdisplay), 0600); err != nil {
 			return err
 		}
-		vncurl := "vnc://:" + vncpasswd + "@" + net.JoinHostPort(vnchost, vncport)
-		logrus.Infof("VNC server running at <%s>", vncurl)
-		logrus.Infof("VNC Display: \"%s\" `%s`", vncdisplay, vncfile)
-		logrus.Infof("VNC Password: \"%s\" `%s`", vncpasswd, vncpwdfile)
+		vncurl := "vnc://" + net.JoinHostPort(vnchost, vncport)
+		logrus.Infof("VNC server running at %s <%s>", vncdisplay, vncurl)
+		logrus.Infof("VNC Display: `%s`", vncfile)
+		logrus.Infof("VNC Password: `%s`", vncpwdfile)
 	}
 
 	stBase := events.Status{

Original file line number	Diff line number	Diff line change
`@@ -303,10 +303,10 @@ func (a *HostAgent) Run(ctx context.Context) error {`
`303`	`303`	`if err := os.WriteFile(vncfile, []byte(vncdisplay), 0600); err != nil {`
`304`	`304`	`return err`
`305`	`305`	`}`
`306`		`- vncurl := "vnc://:" + vncpasswd + "@" + net.JoinHostPort(vnchost, vncport)`
`307`		`- logrus.Infof("VNC server running at <%s>", vncurl)`
`308`		- logrus.Infof("VNC Display: \"%s\" `%s`", vncdisplay, vncfile)
`309`		- logrus.Infof("VNC Password: \"%s\" `%s`", vncpasswd, vncpwdfile)
	`306`	`+ vncurl := "vnc://" + net.JoinHostPort(vnchost, vncport)`
	`307`	`+ logrus.Infof("VNC server running at %s <%s>", vncdisplay, vncurl)`
	`308`	+ logrus.Infof("VNC Display: `%s`", vncfile)
	`309`	+ logrus.Infof("VNC Password: `%s`", vncpwdfile)
`310`	`310`	`}`
`311`	`311`
`312`	`312`	`stBase := events.Status{`