Merge pull request #3470 from alexandear-org/enable-usetesting

Enable usetesting linter

Author: jandubois

.golangci.yml

@@ -26,6 +26,7 @@ linters:
   - revive
   - staticcheck
   - unused
+  - usetesting
   - whitespace
   settings:
     depguard:
@@ -119,6 +120,8 @@ linters:
       - -ST1000
       - -ST1001  # duplicates revive.dot-imports
       - -ST1022
+    usetesting:
+      os-temp-dir: true
   exclusions:
     presets:
     - common-false-positives

pkg/limayaml/defaults_test.go

@@ -148,7 +148,7 @@ func TestFillDefault(t *testing.T) {
 		Mounts: []Mount{
 			// Location will be passed through localpathutil.Expand() which will normalize the name
 			// (add a drive letter). So we must start with a valid local path to match it again later.
-			{Location: filepath.Clean(os.TempDir())},
+			{Location: filepath.Clean(t.TempDir())},
 			{Location: "{{.Dir}}/{{.Param.ONE}}", MountPoint: ptr.Of("/mnt/{{.Param.ONE}}")},
 		},
 		MountType: ptr.Of(NINEP),