Skip to content

Enable usetesting linter #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Enable usetesting linter #3470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ linters:
- revive
- staticcheck
- unused
- usetesting
- whitespace
settings:
depguard:
Expand Down Expand Up @@ -119,6 +120,8 @@ linters:
- -ST1000
- -ST1001 # duplicates revive.dot-imports
- -ST1022
usetesting:
os-temp-dir: true
exclusions:
presets:
- common-false-positives
Expand Down
2 changes: 1 addition & 1 deletion pkg/limayaml/defaults_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func TestFillDefault(t *testing.T) {
Mounts: []Mount{
// Location will be passed through localpathutil.Expand() which will normalize the name
// (add a drive letter). So we must start with a valid local path to match it again later.
{Location: filepath.Clean(os.TempDir())},
{Location: filepath.Clean(t.TempDir())},
{Location: "{{.Dir}}/{{.Param.ONE}}", MountPoint: ptr.Of("/mnt/{{.Param.ONE}}")},
},
MountType: ptr.Of(NINEP),
Expand Down
Loading