-
Notifications
You must be signed in to change notification settings - Fork 758
Refactor: Remove driver.BaseDriver, move drivers and image-downloader to pkg/driver #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexandear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint issues.
e43fdff to
3bb3e7b
Compare
…iver, move drivers and image-downloader to pkg/driver Signed-off-by: Ansuman Sahoo <[email protected]>
3bb3e7b to
5389e27
Compare
|
Why do we still need sshLocalPort as a parameter, and not just instance? Is that for the obsolete 60022 Eventually I wanted to refactor it into host and port (and not hardcode localhost), but that's a separate topic |
AkihiroSuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm merging this.
The comment about the ssh port can be addressed separately
|
This PR disables kernel decompression for vz instances. Line 45 in b94e2fc
after: Line 120 in d32847c
Since
|
This pull request introduces a significant architectural refactoring to the driver implementation in Lima. It is the foundational first part of the larger GSoC project and prepares the codebase for upcoming features by improving modularity and support for external drivers. This PR sets the project structure and refactoring needed for the next three submissions.
Key Changes
driver.BaseDriver: TheBaseDriverstruct has been removed. Interface functions are implemented directly within the specific drivers.pkg/driver/directory. This co-locates driver code (e.g.,pkg/qemuis nowpkg/driver/qemu).GSoC Context
This is the 1st of 4 PRs that make up my initial GSoC project submission for mid-term evaluations. Merging this foundational PR is a prerequisite for the subsequent three, which will build upon this new architecture.
Related Issues
pkg/{qemu,vz,wsl2}topkg/driver#3499BaseDriverstruct #3567