Skip to content

Derive Eq and Hash on InterpolationAlphaSpace #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

Derive Eq and Hash on InterpolationAlphaSpace #148

merged 2 commits into from
Oct 6, 2025

Conversation

@sagudev
Copy link
Contributor

@sagudev sagudev commented Oct 6, 2025

This is needed to implement unpremultiplied alpha interpolation in vello classic, because of https://github.com/linebender/vello/blob/59460521d4487f1d285cad45c7b4daabf0d95161/vello_encoding/src/ramp_cache.rs#L24

DJMcNab
DJMcNab approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change on its own seems fine, although we probably should try to unify this set of derives for all the enums (i.e. adding Hash elsewhere, at least for C-like enums).

This was referenced Oct 6, 2025
Draft
Open
@sagudev sagudev added this pull request to the merge queue Oct 6, 2025
Merged via the queue into linebender:main with commit 36fba07 Oct 6, 2025
15 checks passed
@sagudev sagudev deleted the interp-eq-hash branch October 6, 2025 08:48
@sagudev sagudev mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sagudev @DJMcNab