@@ -1604,7 +1604,7 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
16041604 int bytes_not_copied ;
16051605 struct i40e_vsi * vsi ;
16061606 int vsi_seid ;
1607- int i , cnt ;
1607+ int i , ret ;
16081608
16091609 /* don't allow partial writes */
16101610 if (* ppos != 0 )
@@ -1629,9 +1629,9 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
16291629 if (strncmp (cmd_buf , "change_mtu" , 10 ) == 0 ) {
16301630 int mtu ;
16311631
1632- cnt = sscanf (& cmd_buf [11 ], "%i %i" ,
1632+ ret = sscanf (& cmd_buf [11 ], "%i %i" ,
16331633 & vsi_seid , & mtu );
1634- if (cnt != 2 ) {
1634+ if (ret != 2 ) {
16351635 dev_info (& pf -> pdev -> dev , "change_mtu <vsi_seid> <mtu>\n" );
16361636 goto netdev_ops_write_done ;
16371637 }
@@ -1652,8 +1652,8 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
16521652 }
16531653
16541654 } else if (strncmp (cmd_buf , "set_rx_mode" , 11 ) == 0 ) {
1655- cnt = sscanf (& cmd_buf [11 ], "%i" , & vsi_seid );
1656- if (cnt != 1 ) {
1655+ ret = kstrtoint (& cmd_buf [11 ], 0 , & vsi_seid );
1656+ if (ret ) {
16571657 dev_info (& pf -> pdev -> dev , "set_rx_mode <vsi_seid>\n" );
16581658 goto netdev_ops_write_done ;
16591659 }
@@ -1673,8 +1673,8 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,
16731673 }
16741674
16751675 } else if (strncmp (cmd_buf , "napi" , 4 ) == 0 ) {
1676- cnt = sscanf (& cmd_buf [4 ], "%i" , & vsi_seid );
1677- if (cnt != 1 ) {
1676+ ret = kstrtoint (& cmd_buf [4 ], 0 , & vsi_seid );
1677+ if (ret ) {
16781678 dev_info (& pf -> pdev -> dev , "napi <vsi_seid>\n" );
16791679 goto netdev_ops_write_done ;
16801680 }
0 commit comments