Skip to content

Commit 2427242

Browse files
MaskRayyuxuanchen1997
authored andcommitted
[MC] Make *ObjectWriter final
Summary: to make it clear that target customization should be done by inheriting from MCObjectTargetWriter subclasses instead of MCObjectWriter subclasses. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251094
1 parent 76e8205 commit 2427242

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

llvm/include/llvm/MC/MCELFObjectWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class MCELFObjectTargetWriter : public MCObjectTargetWriter {
154154
}
155155
};
156156

157-
class ELFObjectWriter : public MCObjectWriter {
157+
class ELFObjectWriter final : public MCObjectWriter {
158158
unsigned ELFHeaderEFlags = 0;
159159

160160
public:

llvm/include/llvm/MC/MCMachObjectWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class MCMachObjectTargetWriter : public MCObjectTargetWriter {
8383
/// @}
8484
};
8585

86-
class MachObjectWriter : public MCObjectWriter {
86+
class MachObjectWriter final : public MCObjectWriter {
8787
public:
8888
struct DataRegionData {
8989
MachO::DataRegionType Kind;

llvm/include/llvm/MC/MCWinCOFFObjectWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class MCWinCOFFObjectTargetWriter : public MCObjectTargetWriter {
4545

4646
class WinCOFFWriter;
4747

48-
class WinCOFFObjectWriter : public MCObjectWriter {
48+
class WinCOFFObjectWriter final : public MCObjectWriter {
4949
friend class WinCOFFWriter;
5050

5151
std::unique_ptr<MCWinCOFFObjectTargetWriter> TargetObjectWriter;

0 commit comments

Comments
 (0)