fix testcase and fix root reason about crash with tomasz-kaminski-sonarsource's help

Author: miaozhiyuan

clang/lib/StaticAnalyzer/Core/CallEvent.cpp

@@ -1409,7 +1409,7 @@ CallEventManager::getSimpleCall(const CallExpr *CE, ProgramStateRef State,
   if (const auto *OpCE = dyn_cast<CXXOperatorCallExpr>(CE)) {
     const FunctionDecl *DirectCallee = OpCE->getDirectCallee();
     if (const auto *MD = dyn_cast<CXXMethodDecl>(DirectCallee))
-      if (MD->isInstance())
+      if (MD->isImplicitObjectMemberFunction())
         return create<CXXMemberOperatorCall>(OpCE, State, LCtx, ElemRef);
 
   } else if (CE->getCallee()->getType()->isBlockPointerType()) {

clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

@@ -354,13 +354,8 @@ SVal ExprEngine::computeObjectUnderConstruction(
         // Operator arguments do not correspond to operator parameters
         // because this-argument is implemented as a normal argument in
         // operator call expressions but not in operator declarations.
-        std::optional<unsigned int> Index =
-            Caller->getAdjustedParameterIndex(Idx);
-        if (!Index) {
-          return std::nullopt;
-        }
-        const TypedValueRegion *TVR =
-            Caller->getParameterLocation(*Index, BldrCtx->blockCount());
+        const TypedValueRegion *TVR = Caller->getParameterLocation(
+            *Caller->getAdjustedParameterIndex(Idx), BldrCtx->blockCount());
         if (!TVR)
           return std::nullopt;
 

clang/test/Analysis/engine/expr-engine-cxx-crash.cpp

@@ -1,15 +1,11 @@
-// RUN: %clang_analyze_cc1 -analyzer-checker=core.DivideZero -std=c++23 -verify %s
+// RUN: %clang_analyze_cc1 -analyzer-checker=core -std=c++23 -verify %s
 // expected-no-diagnostics
 
-struct S
-{
-    constexpr auto operator==(this auto, S)
-    {
-        return true;
-    }
+struct S {
+  bool operator==(this auto, S) {
+    return true;
+  }
 };
-
-int main()
-{
-    return S {} == S {};
+int use_deducing_this() {
+  return S{} == S{};
 }