[X86] Failure to reduce extended i64 add/sub/mul arithmetic to i32 with known zeros in the upper 32-bits

[RKSimon]

https://c.godbolt.org/z/3Gv4rPEGq

As noted on #141360 - x86 i64 add/sub/mul arithmetic is not reduced to i32 arithmetic when the upper 32-bits are known to be zero (and can be implicitly zero-extended). We do appear to do this for logic and shift instructions.

On recent CPU targets, ADD/SUB i64 is usually just as cheap as i32 equivalents but MUL can often still benefit, and there's potential for shorter instruction encodings for all of them.

We can either handle this with combineAdd/Sub/Mul in X86ISelLowering.cpp or we can wait until X86ISelDAGToDAG.cpp

[llvmbot]

@llvm/issue-subscribers-backend-x86

Author: Simon Pilgrim (RKSimon)

https://c.godbolt.org/z/3Gv4rPEGq

As noted on #141360 - x86 i64 add/sub/mul arithmetic is not reduced to i32 arithmetic when the upper 32-bits are known to be zero (and can be implicitly zero-extended). We do appear to do this for logic and shift instructions.

On recent CPU targets, ADD/SUB i64 is usually just as cheap as i32 equivalents but MUL can often still benefit, and there's potential for shorter instruction encodings for all of them.

We can either handle this with combineAdd/Sub/Mul in X86ISelLowering.cpp or we can wait until X86ISelDAGToDAG.cpp

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Simon Pilgrim (RKSimon)

https://c.godbolt.org/z/3Gv4rPEGq

As noted on #141360 - x86 i64 add/sub/mul arithmetic is not reduced to i32 arithmetic when the upper 32-bits are known to be zero (and can be implicitly zero-extended). We do appear to do this for logic and shift instructions.

On recent CPU targets, ADD/SUB i64 is usually just as cheap as i32 equivalents but MUL can often still benefit, and there's potential for shorter instruction encodings for all of them.

We can either handle this with combineAdd/Sub/Mul in X86ISelLowering.cpp or we can wait until X86ISelDAGToDAG.cpp

[omkar-mohanty]

Hi @RKSimon , I'd like to work on this issue. 🙂

[RKSimon]

@omkar-mohanty ping?

[RKSimon]

@omkar-mohanty are you able to continue with this soon? otherwise we should allow reassignment

@harsh241082 are you interested in starting with the mul_i64 narrowing?