[clang] Ungrammatical "a enum specifier" error message

[Rajveer100]

Clang throws ungrammatical error message for alias.

GodBolt

Old:

error: type alias 'A' cannot be referenced with a enum specifier

New:

error: type alias 'A' cannot be referenced with the 'enum' specifier

This can be rephrased for other cases as well, ex:

template<class T> using A = int;
struct A s;

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Rajveer Singh Bharadwaj (Rajveer100)

Clang throws ungrammatical error message for alias.

GodBolt

Old:

error: type alias 'A' cannot be referenced with a enum specifier

New:

error: alias 'A' cannot be referenced with the 'enum' specifier

This can be changed similarly for other cases as well.

[kper]

I would like to take that :)

[akshaykumars614]

I am new here, but the error message seems to be correct as A is a type alias here. But as I can see, it is being changed to alias. Please correct me if I am wrong. @Rajveer100

[Rajveer100]

@akshaykumars614
Apologies, I have updated the issue description.

[Rajveer100]

For the new snippet in the description, it would be applicable:

template<class T> using A = int;
struct A s;

Old: type alias template 'A' cannot be referenced with a struct specifier
New: alias template 'A' cannot be referenced with the 'struct' specifier

[kper]

@Rajveer100 is the change from old to new just a grammar change or do I have to change the analysis?

Old: type alias template...
New: alias template...

[Rajveer100]

It's a grammatical change.