Adopt examples to Kuberentes v1.23 #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjura
force-pushed
the
examples-v1.23
branch
from
ba0beed to
ffdca97
Compare
vadorovsky
requested changes
Dec 15, 2021
Member
There was a problem hiding this comment.
The change itself looks good to me.
But please start referencing issues. Put Fixes: #117 into your commit message and PR description. Like:
Adopt examples to Kuberentes v1.23
In Kubernetes v1.23 new admission controller requires securityContext
for application deployed in restricted namespaces. We need to update
lockc example deployment.
Fixes: #117
Signed-off-by: Michal Jura <[email protected]>
Thanks to that kind of reference, issues get closed when PRs get merged.
In Kubernetes v1.23 new admission controller requires securityContext for application deployed in restricted namespaces. We need to update lockc example deployment. Fixes: lockc-project#117 Signed-off-by: Michal Jura <[email protected]>
mjura
force-pushed
the
examples-v1.23
branch
from
ffdca97 to
983085e
Compare
vadorovsky
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kubernetes v1.23 new admission controller requires securityContext
for application deployed in restricted namespaces. We need to update
lockc example deployment.
Fixes: #117
Signed-off-by: Michal Jura [email protected]