Skip to content

Commit b4a0a36

Browse files
authored
Merge pull request #3 from swatisehgal/update-imple-details
Ensure Implementation stategy captured in the KEP matches latest implementation
2 parents eb1fc6b + 601e950 commit b4a0a36

File tree

1 file changed

+1
-1
lines changed
  • keps/sig-node/2625-cpumanager-policies-thread-placement

1 file changed

+1
-1
lines changed

keps/sig-node/2625-cpumanager-policies-thread-placement/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Key properties:
122122

123123
- The CPU Manager implements the pod admit handler interface and participates in Kubelet pod admission.
124124
- The `GetAllocateResourcesPodAdmitHandler()` function in the Container Manager is modified to perform admission checks for CPU Manager in addition to the already occurring Topology manager admission check.
125-
Just like Topology Manager returns `TopologyAffinityError` is case of resources cannot be NUMA-aligned in case of `restricted` or `single-numa-node policy`, CPU Manager admission failure results in a rejected pod with `SMTAlignmentError`. If both CPU Manager and Topology manager don't allow pod to be admitted `ContainerManagerAdmissionError` is returned to indicate that both the admit handlers are not allowing pod to be admitted.
125+
Just like Topology Manager returns `TopologyAffinityError` is case of resources cannot be NUMA-aligned in case of `restricted` or `single-numa-node policy`, CPU Manager admission failure results in a rejected pod with `SMTAlignmentError`.
126126
- The Policy interface in CPU Manager is enhanced to support an Admit function. This allows to perform pod admission decision for CPU Manager policies.
127127
- When CPU Manager is configured with `smtaware` policy, when the `Admit()` function is called it is checked if the CPU request is
128128
such that it would acquire an entire physical core. In case request translates to partial occupancy of the cores the Pod will not be admitted and would fail with `SMTAlignmentError`. In case of `static` and `none` policy, the Admit() function always returns true meaning the pod is always admitted.

0 commit comments

Comments
 (0)