DEV-49046 Fix the internal IP cannot found bug in argus

Author: jeremy

pkg/watch/node/node.go

@@ -151,17 +151,17 @@ func (w *Watcher) args(node *v1.Node, category string) []types.DeviceOption {
 
 // getInternalAddress finds the node's internal address.
 func getInternalAddress(addresses []v1.NodeAddress) *v1.NodeAddress {
-	var hostname v1.NodeAddress
+	var hostname *v1.NodeAddress
 	for _, address := range addresses {
 		if address.Type == v1.NodeInternalIP {
 			return &address
 		}
 		if address.Type == v1.NodeHostName {
-			hostname = address
+			hostname = &address
 		}
 	}
 	//if there is no internal IP for this node, the host name will be used
-	return &hostname
+	return hostname
 }
 
 func (w *Watcher) createRoleDeviceGroup(labels map[string]string) {

pkg/watch/node/node_test.go

@@ -0,0 +1,33 @@
+package node
+
+import (
+	"k8s.io/api/core/v1"
+	"testing"
+)
+
+func TestGetInternalAddress(t *testing.T) {
+	var addresses []v1.NodeAddress
+	address := getInternalAddress(addresses)
+	if address != nil {
+		t.Errorf("invalid address: %v", address)
+	}
+	addresses = append(addresses, v1.NodeAddress{
+		Type:    v1.NodeHostName,
+		Address: "test",
+	})
+
+	address = getInternalAddress(addresses)
+	if address == nil || address.Address != "test" {
+		t.Errorf("invalid address: %v", address)
+	}
+
+	addresses = append(addresses, v1.NodeAddress{
+		Type:    v1.NodeInternalIP,
+		Address: "127.0.0.1",
+	})
+
+	address = getInternalAddress(addresses)
+	if address == nil || address.Address != "127.0.0.1" {
+		t.Errorf("invalid address: %v", address)
+	}
+}