Merge pull request #49 in DEV/k8s-argus from bugfix/DEV-59446-deleted-namespaces-are-still-present-on-the-portal to develop

* commit 'd0fb53894f1475979f48653c6438318faa3085b0':
  DEV-59446 delete namespace code refactored
  DEV-59446 delete namespace code refactored
  DEV-59446 fixed deleted namespaces present on portal issue

Author: lmvaibhavk

pkg/devicegroup/devicegroup.go

@@ -131,6 +131,26 @@ func Find(parentID int32, name string, client *client.LMSdkGo) (*models.DeviceGr
 	return deviceGroup, nil
 }
 
+// FindDeviceGroupsByName searches for a device group by name.
+func FindDeviceGroupsByName(name string, client *client.LMSdkGo) ([]*models.DeviceGroup, error) {
+	params := lm.NewGetDeviceGroupListParams()
+	fields := "name,id,parentId,subGroups"
+	params.SetFields(&fields)
+	filter := fmt.Sprintf("name:\"%s\"", name)
+	params.SetFilter(&filter)
+	restResponse, err := client.LM.GetDeviceGroupList(params)
+	if err != nil {
+		return nil, err
+	}
+
+	var deviceGroups []*models.DeviceGroup
+	if restResponse != nil && restResponse.Payload != nil {
+		deviceGroups = restResponse.Payload.Items
+	}
+
+	return deviceGroups, nil
+}
+
 // Exists returns true if the specified device group exists in the account
 func Exists(parentID int32, name string, client *client.LMSdkGo) bool {
 	deviceGroup, err := Find(parentID, name, client)
@@ -185,6 +205,19 @@ func DeleteSubGroup(deviceGroup *models.DeviceGroup, name string, client *client
 	return nil
 }
 
+// DeleteGroup deletes a device group with the specified deviceGroupID.
+func DeleteGroup(deviceGroup *models.DeviceGroup, client *client.LMSdkGo) error {
+	params := lm.NewDeleteDeviceGroupByIDParams()
+	params.ID = deviceGroup.ID
+	deleteChildren := true
+	params.SetDeleteChildren(&deleteChildren)
+	deleteHard := true
+	params.SetDeleteHard(&deleteHard)
+	log.Infof("Deleting deviceGroup:\"%s\" ID:\"%d\" ParentID:\"%d\"", *deviceGroup.Name, deviceGroup.ID, deviceGroup.ParentID)
+	_, err := client.LM.DeleteDeviceGroupByID(params)
+	return err
+}
+
 func create(name, appliesTo string, disableAlerting bool, parentID int32, client *client.LMSdkGo) (*models.DeviceGroup, error) {
 	params := lm.NewAddDeviceGroupParams()
 	params.SetBody(&models.DeviceGroup{

pkg/watch/namespace/namespace.go

@@ -95,22 +95,28 @@ func (w *Watcher) DeleteFunc() func(obj interface{}) {
 		namespace := obj.(*v1.Namespace)
 		log.Debugf("Handle deleting namespace event: %s", namespace.Name)
 
-		for name, parentID := range w.DeviceGroups {
-			deviceGroup, err := devicegroup.Find(parentID, name, w.LMClient)
-			if err != nil {
-				log.Warnf("Failed to find namespace %s: %v", name, err)
-				return
-			}
-			// We should only be returned a device group if it is namespaced.
-			if deviceGroup == nil {
-				continue
-			}
-			err = devicegroup.DeleteSubGroup(deviceGroup, namespace.Name, w.LMClient)
-			if err != nil {
-				log.Errorf("Failed to delete namespace %q: %v", namespace.Name, err)
-				return
+		deviceGroups, err := devicegroup.FindDeviceGroupsByName(namespace.Name, w.LMClient)
+		if err != nil {
+			log.Errorf("Failed to get device group for namespace:\"%s\" with error: %v", namespace.Name, err)
+			return
+		}
+
+		reversedDeviceGroups := getReversedDeviceGroups(w.DeviceGroups)
+		for _, d := range deviceGroups {
+			if _, ok := reversedDeviceGroups[d.ParentID]; ok {
+				err = devicegroup.DeleteGroup(d, w.LMClient)
+				if err != nil {
+					log.Errorf("Failed to delete device group of namespace:\"%s\" having ID:\"%d\" with error: %v", namespace.Name, d.ID, err)
+				}
 			}
 		}
+	}
+}
 
+func getReversedDeviceGroups(deviceGroups map[string]int32) map[int32]string {
+	reversedDeviceGroups := make(map[int32]string)
+	for key, value := range deviceGroups {
+		reversedDeviceGroups[value] = key
 	}
+	return reversedDeviceGroups
 }