Skip to content

Healthcheck fails in weird ways when response is an HTTP 404 #954

@yaauie

Description

@yaauie

ManticoreAdapter#perform_request explicitly counts an HTTP 404 as a non-exceptional condition, which allows the healthcheck to get into a weird state when reviving a connection (which can occur during initialization), specifically when we send Pool#get_es_version(url) and expect the response to be a specific shape.

We need to validate that we received a 2XX level response code from the initial healthcheck ping, ideally one that validates the shape of the repsponse to be Elasticsearch-y, and we need to make the whole code more resilient to non-success paths in Pool#get_es_version(url).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions