Skip to content

Commit 5c3f0e0

Browse files
Ihor BilousIhor Bilous
authored andcommitted
Fix issue #29: make http_client property as private in api classes
1 parent 57a5452 commit 5c3f0e0

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

examples/testing/projects.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,8 @@ def update_project(project_id: str, new_name: str) -> Project:
2222

2323
def delete_project(project_id: str):
2424
return projects_api.delete(project_id)
25+
26+
27+
if __name__ == "__main__":
28+
projects = list_projects()
29+
print(projects)

mailtrap/api/resources/projects.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,35 +5,35 @@
55

66
class ProjectsApi:
77
def __init__(self, client: HttpClient, account_id: str) -> None:
8-
self.account_id = account_id
9-
self.client = client
8+
self._account_id = account_id
9+
self._client = client
1010

1111
def get_list(self) -> list[Project]:
12-
response = self.client.get(f"/api/accounts/{self.account_id}/projects")
12+
response = self._client.get(f"/api/accounts/{self._account_id}/projects")
1313
return [Project(**project) for project in response]
1414

1515
def get_by_id(self, project_id: int) -> Project:
16-
response = self.client.get(
17-
f"/api/accounts/{self.account_id}/projects/{project_id}"
16+
response = self._client.get(
17+
f"/api/accounts/{self._account_id}/projects/{project_id}"
1818
)
1919
return Project(**response)
2020

2121
def create(self, project_name: str) -> Project:
22-
response = self.client.post(
23-
f"/api/accounts/{self.account_id}/projects",
22+
response = self._client.post(
23+
f"/api/accounts/{self._account_id}/projects",
2424
json={"project": {"name": project_name}},
2525
)
2626
return Project(**response)
2727

2828
def update(self, project_id: int, project_name: str) -> Project:
29-
response = self.client.patch(
30-
f"/api/accounts/{self.account_id}/projects/{project_id}",
29+
response = self._client.patch(
30+
f"/api/accounts/{self._account_id}/projects/{project_id}",
3131
json={"project": {"name": project_name}},
3232
)
3333
return Project(**response)
3434

3535
def delete(self, project_id: int) -> DeletedObject:
36-
response = self.client.delete(
37-
f"/api/accounts/{self.account_id}/projects/{project_id}",
36+
response = self._client.delete(
37+
f"/api/accounts/{self._account_id}/projects/{project_id}",
3838
)
3939
return DeletedObject(**response)

mailtrap/api/testing.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ class TestingApi:
88
def __init__(
99
self, client: HttpClient, account_id: str, inbox_id: Optional[str] = None
1010
) -> None:
11-
self.account_id = account_id
12-
self.inbox_id = inbox_id
13-
self.client = client
11+
self._account_id = account_id
12+
self._inbox_id = inbox_id
13+
self._client = client
1414

1515
@property
1616
def projects(self) -> ProjectsApi:
17-
return ProjectsApi(account_id=self.account_id, client=self.client)
17+
return ProjectsApi(account_id=self._account_id, client=self._client)

0 commit comments

Comments
 (0)