MLE-11468: Implementation and unit test for Ingress #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkhachoithani
requested review from
pengzhouml,
rwinieski,
sumanthravipati and
vitalykorolev
pengzhouml
requested changes
Oct 15, 2024
| func generateIngressDef(ingressMeta metav1.ObjectMeta, ownerRef metav1.OwnerReference, cr *databasev1alpha1.MarklogicCluster) *networkingv1.Ingress { | ||
| pathType := networkingv1.PathTypePrefix | ||
| var ingressRules []networkingv1.IngressRule | ||
| for _, appServer := range cr.Spec.HAProxy.AppServers { |
Collaborator
There was a problem hiding this comment.
The Logic Here does not seems correct to me.
According to your code, if a path is not 8000, 8001, 8002, it will go to additional port.
However, there could be 0 additional port, and have another path like /datahub for 8010 in the same host.
We need to discuss more about how Ingress and HAProxy rule could work together. And what the role of Additional Host plays here.
pengzhouml
requested changes
Oct 15, 2024
api/v1alpha1/common_types.go
Outdated
| Labels map[string]string `json:"labels,omitempty"` | ||
| Annotations map[string]string `json:"annotations,omitempty"` | ||
| Host string `json:"host,omitempty"` | ||
| Tls networkingv1.IngressTLS `json:"tls,omitempty"` |
Collaborator
There was a problem hiding this comment.
Tls for Ingress is optional, so the type should be *networkingv1.IngressTLS.
pkg/k8sutil/ingress.go
Outdated
| ingressSpec := networkingv1.IngressSpec{ | ||
| IngressClassName: &cr.Spec.Ingress.IngressClassName, | ||
| Rules: ingressRules, | ||
| TLS: []networkingv1.IngressTLS{ |
Collaborator
There was a problem hiding this comment.
TLS for Ingress Should be optional.
pengzhouml
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.