-
Notifications
You must be signed in to change notification settings - Fork 84
Fix GPU training in inverse problem #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dario-coscia
merged 1 commit into
mathLab:new_pinns
from
annaivagnes:fix_bug_inverse_problem
Apr 8, 2024
Merged
Fix GPU training in inverse problem #283
dario-coscia
merged 1 commit into
mathLab:new_pinns
from
annaivagnes:fix_bug_inverse_problem
Apr 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-coscia
approved these changes
Apr 8, 2024
Collaborator
dario-coscia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
dario-coscia
pushed a commit
that referenced
this pull request
Apr 15, 2024
dario-coscia
pushed a commit
that referenced
this pull request
Apr 30, 2024
dario-coscia
pushed a commit
that referenced
this pull request
Apr 30, 2024
dario-coscia
added a commit
that referenced
this pull request
May 10, 2024
* gpinn/basepinn new classes, pinn restructure * codacy fix gpinn/basepinn/pinn * inverse problem fix * Causal PINN (#267) * fix GPU training in inverse problem (#283) * Create a `compute_residual` attribute for `PINNInterface` * Modify dataloading in solvers (#286) * Modify PINNInterface by removing _loss_phys, _loss_data * Adding in PINNInterface a variable to track the current condition during training * Modify GPINN,PINN,CausalPINN to match changes in PINNInterface * Competitive Pinn Addition (#288) * fixing after rebase/ fix loss * fixing final issues --------- Co-authored-by: Dario Coscia <[email protected]> * Modify min max formulation to max min for paper consistency * Adding SAPINN solver (#291) * rom solver * fix import --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Anna Ivagnes <[email protected]> Co-authored-by: valc89 <[email protected]> Co-authored-by: Monthly Tag bot <[email protected]> Co-authored-by: Nicola Demo <[email protected]>
ndem0
added a commit
that referenced
this pull request
Sep 9, 2024
* gpinn/basepinn new classes, pinn restructure * codacy fix gpinn/basepinn/pinn * inverse problem fix * Causal PINN (#267) * fix GPU training in inverse problem (#283) * Create a `compute_residual` attribute for `PINNInterface` * Modify dataloading in solvers (#286) * Modify PINNInterface by removing _loss_phys, _loss_data * Adding in PINNInterface a variable to track the current condition during training * Modify GPINN,PINN,CausalPINN to match changes in PINNInterface * Competitive Pinn Addition (#288) * fixing after rebase/ fix loss * fixing final issues --------- Co-authored-by: Dario Coscia <[email protected]> * Modify min max formulation to max min for paper consistency * Adding SAPINN solver (#291) * rom solver * fix import --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Anna Ivagnes <[email protected]> Co-authored-by: valc89 <[email protected]> Co-authored-by: Monthly Tag bot <[email protected]> Co-authored-by: Nicola Demo <[email protected]>
ndem0
added a commit
that referenced
this pull request
Sep 9, 2024
* gpinn/basepinn new classes, pinn restructure * codacy fix gpinn/basepinn/pinn * inverse problem fix * Causal PINN (#267) * fix GPU training in inverse problem (#283) * Create a `compute_residual` attribute for `PINNInterface` * Modify dataloading in solvers (#286) * Modify PINNInterface by removing _loss_phys, _loss_data * Adding in PINNInterface a variable to track the current condition during training * Modify GPINN,PINN,CausalPINN to match changes in PINNInterface * Competitive Pinn Addition (#288) * fixing after rebase/ fix loss * fixing final issues --------- Co-authored-by: Dario Coscia <[email protected]> * Modify min max formulation to max min for paper consistency * Adding SAPINN solver (#291) * rom solver * fix import --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Anna Ivagnes <[email protected]> Co-authored-by: valc89 <[email protected]> Co-authored-by: Monthly Tag bot <[email protected]> Co-authored-by: Nicola Demo <[email protected]>
dario-coscia
added a commit
that referenced
this pull request
Mar 12, 2025
* gpinn/basepinn new classes, pinn restructure * codacy fix gpinn/basepinn/pinn * inverse problem fix * Causal PINN (#267) * fix GPU training in inverse problem (#283) * Create a `compute_residual` attribute for `PINNInterface` * Modify dataloading in solvers (#286) * Modify PINNInterface by removing _loss_phys, _loss_data * Adding in PINNInterface a variable to track the current condition during training * Modify GPINN,PINN,CausalPINN to match changes in PINNInterface * Competitive Pinn Addition (#288) * fixing after rebase/ fix loss * fixing final issues --------- Co-authored-by: Dario Coscia <[email protected]> * Modify min max formulation to max min for paper consistency * Adding SAPINN solver (#291) * rom solver * fix import --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Anna Ivagnes <[email protected]> Co-authored-by: valc89 <[email protected]> Co-authored-by: Monthly Tag bot <[email protected]> Co-authored-by: Nicola Demo <[email protected]>
dario-coscia
added a commit
that referenced
this pull request
Apr 17, 2025
* gpinn/basepinn new classes, pinn restructure * codacy fix gpinn/basepinn/pinn * inverse problem fix * Causal PINN (#267) * fix GPU training in inverse problem (#283) * Create a `compute_residual` attribute for `PINNInterface` * Modify dataloading in solvers (#286) * Modify PINNInterface by removing _loss_phys, _loss_data * Adding in PINNInterface a variable to track the current condition during training * Modify GPINN,PINN,CausalPINN to match changes in PINNInterface * Competitive Pinn Addition (#288) * fixing after rebase/ fix loss * fixing final issues --------- Co-authored-by: Dario Coscia <[email protected]> * Modify min max formulation to max min for paper consistency * Adding SAPINN solver (#291) * rom solver * fix import --------- Co-authored-by: Dario Coscia <[email protected]> Co-authored-by: Anna Ivagnes <[email protected]> Co-authored-by: valc89 <[email protected]> Co-authored-by: Monthly Tag bot <[email protected]> Co-authored-by: Nicola Demo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #281: in
pina/trainer.pyadd the conversion of device for the unknown parameters in the inverse problem.