Skip to content

Conversation

@AleDinve
Copy link
Contributor

Equation class tutorial (see #248)

@dario-coscia
Copy link
Collaborator

dario-coscia commented Apr 16, 2024

Hi! Thanks for the PR! Some conflicts are going on, can you solve them? Did you fetch and rebase with master?

@dario-coscia dario-coscia added the pr-to-fix Label for PR that needs modification label Apr 16, 2024
@dario-coscia
Copy link
Collaborator

dario-coscia commented Apr 17, 2024

Hi! Thanks for the PR! Some conflicts are going on, can you solve them? Did you fetch and rebase with master?

👋🏻 @AleDinve there were some issues with the GitHub history, I fixed them. I uploaded the tutorial12/tutorial.ipynb and tutorial12/tutorial.py.

Can you update the ReadMe.md in tutorials, the _tutorial.rst file in docs/source/_rst and add the tutorial12 folder in docs/source/_rst/tutorials ?

Then we merge!

@AleDinve
Copy link
Contributor Author

Solved 👍

@dario-coscia dario-coscia self-requested a review April 18, 2024 11:14
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Apr 18, 2024
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AleDinve ! 👏

@dario-coscia dario-coscia merged commit 7b86661 into mathLab:master Apr 18, 2024
ndem0 pushed a commit that referenced this pull request Sep 9, 2024
* Tutorial Equation 12
* .rst and readme fix for tutorial12
* small fix
* modified rst

---------

Co-authored-by: Dario Coscia <[email protected]>
ndem0 pushed a commit that referenced this pull request Sep 9, 2024
* Tutorial Equation 12
* .rst and readme fix for tutorial12
* small fix
* modified rst

---------

Co-authored-by: Dario Coscia <[email protected]>
dario-coscia pushed a commit that referenced this pull request Mar 12, 2025
* Tutorial Equation 12
* .rst and readme fix for tutorial12
* small fix
* modified rst

---------

Co-authored-by: Dario Coscia <[email protected]>
dario-coscia pushed a commit that referenced this pull request Apr 17, 2025
* Tutorial Equation 12
* .rst and readme fix for tutorial12
* small fix
* modified rst

---------

Co-authored-by: Dario Coscia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants