Add link to git commit for unstable changelog too #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually this doesn't work because the unstable changelog file is not committed to the repository. |
zecakeh
force-pushed
the
unstable-commit
branch
from
6aaa8a2 to
7cf4a17
Compare
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
unstable-commit
branch
from
7cf4a17 to
149a0e9
Compare
Contributor
Author
|
It's fixed now. |
richvdh
reviewed
Mar 4, 2025
Signed-off-by: Kévin Commaille <[email protected]>
richvdh
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if it closes #1612. It says "somewhere on the page", so on every page of the spec, but here we do it only on the unstable changelog page, which might be enough?
If we want to show it on every page, it will probably require to copy the commit hash in the config file or something like that.
Pull Request Checklist
Preview: https://pr2078--matrix-spec-previews.netlify.app